Page MenuHome

Fix T77900: File Browser in macOS fullscreen crashes
AbandonedPublic

Authored by Julian Eisel (Severin) on Aug 27 2020, 5:10 PM.

Details

Summary
NOTE: Re-submitting this (was previously reviewed in D8708) for backporting to 2.90.

When Blender is started in fullscreen mode from the command line,
or if the fullscreen state is saved in the startup file, all temporary windows
will also open in fullscreen mode. When closing the fullscreen File Browser,
Blender would either crash or parent window becomes black.

This does not happen if the Blender switches to full screen manually.

NSWindowCollectionBehaviorFullScreenPrimary should be set for windows that
can enter full-screen mode. Otherwise macOS will turn the wrong window into
full-screen.

Similar fix: rB4b39de677d20

Diff Detail

Repository
rB Blender
Branch
blender-v2.90-release
Build Status
Buildable 9849
Build 9849: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Aug 27 2020, 5:10 PM

Seems fine for 2.90.

This revision is now accepted and ready to land.Aug 27 2020, 5:56 PM

Discussed this with the release team: We'd have to delay the release for this fix, which we decided not to do. Should there be a corrective release, I can make sure it's added there.
Closing the patch.