Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 27 2020, 7:40 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Richard Antalik (ISS)

Commits

rC2683ca2fddd2: Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking
rBd3f203796688: Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking

Summary

We forgot to update this code as part of D3108. I'd like to include this in 2.90,
it's entirely broken now so can't really get any worse.

Diff Detail

Repository

rB Blender

Branch

fix-opencl-bake (branched from master)

Build Status

Buildable 9854
Build 9854: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.Aug 27 2020, 7:40 PM

Harbormaster completed remote builds in B9854: Diff 28250.Aug 27 2020, 7:40 PM

Brecht Van Lommel (brecht) requested review of this revision.Aug 27 2020, 7:40 PM

Can confirm that issue is fixed after patching.

This revision is now accepted and ready to land.Aug 28 2020, 3:39 AM

Some minor suggestion for the comment.
Unfortunately, can not test this since I din't have AMD GPU, and NVidia OpenCL doesn't work at all for me for some reason.

intern/cycles/device/opencl/device_opencl_impl.cpp
868	Would be nice to reference a function where the loading happened. Think it will make thing more clear here.

Closed by commit rBd3f203796688: Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking (authored by Brecht Van Lommel (brecht)). · Explain WhyAug 28 2020, 1:01 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBd3f203796688: Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking.

Brecht Van Lommel (brecht) added a commit: rC2683ca2fddd2: Fix T80149: Cycles OpenCL baking broken after changes to uses tiles for baking.Sep 1 2020, 1:59 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

opencl/

device_opencl_impl.cpp

8 lines

kernel/

kernels/

opencl/

kernel_bake.cl

14 lines

Diff 28250

View Options

intern/cycles/device/opencl/device_opencl_impl.cpp