GPU: Fix Segmentation Fault Freeing Failed Shader
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Aug 28 2020, 8:15 AM.

Details

Reviewers

Maniphest Tasks

T80168: Crash if shader compilation fails

Commits

rB5db5ac611a5c: GPU: Fix Segmentation Fault Freeing Failed Shader
rBc28432680971: GPU: Fix Segmentation Fault Freeing Failed Shader

Summary

The CPP Shader class does not initialize the interface attribute.
What will crash when deleting the shader.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Aug 28 2020, 8:15 AM

Jeroen Bakker (jbakker) created this revision.

Jeroen Bakker (jbakker) retitled this revision from GPU: Fix Segmentation error when shader fails to compile to GPU: Fix Segmentation Fault Freeing Failed Shader.

Jeroen Bakker (jbakker) mentioned this in T80168: Crash if shader compilation fails.Aug 28 2020, 11:42 AM

Jeroen Bakker (jbakker) added a task: T80168: Crash if shader compilation fails.

Clément Foucault (fclem) accepted this revision.Aug 28 2020, 1:50 PM

This revision is now accepted and ready to land.Aug 28 2020, 1:50 PM

Well actually I would prefer this

class Shader {
 public:
  /** Uniform & attribute locations for shader. */
  ShaderInterface *interface = NULL;

Closed by commit rBc28432680971: GPU: Fix Segmentation Fault Freeing Failed Shader (authored by Jeroen Bakker (jbakker)). · Explain WhyAug 28 2020, 2:33 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBc28432680971: GPU: Fix Segmentation Fault Freeing Failed Shader.

Jeroen Bakker (jbakker) added a reverting change: rBb8f990b0b4ee: Revert "GPU: Fix Segmentation Fault Freeing Failed Shader".Aug 28 2020, 3:44 PM

Jeroen Bakker (jbakker) added a commit: rB5db5ac611a5c: GPU: Fix Segmentation Fault Freeing Failed Shader.Aug 28 2020, 3:46 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

gpu_shader.cc

2 lines

Diff 28256

View Options

source/blender/gpu/intern/gpu_shader.cc

GPU: Fix Segmentation Fault Freeing Failed ShaderClosedPublicActions