Page MenuHome

Fix T80141: Fix Compiling Workbench Volume Shaders (Mesa 20.0.8)
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Aug 28 2020, 9:00 AM.

Details

Summary

Default mesa driver for ubuntu 20.04 fails when a name is defined twice.
M_PI is defined in both common_workbench_lib and common_math_lib. This patch
remove the define out of common_workbench_lib

For reference it fails on https://github.com/mesa3d/mesa/blob/mesa-20.0.8/src/compiler/glsl/glcpp/glcpp-parse.y#L1186
during the check if the macros are the same.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Aug 28 2020, 9:00 AM
Jeroen Bakker (jbakker) created this revision.
Jeroen Bakker (jbakker) retitled this revision from Workbench: Fix Compiling Workbench Volume Shaders (Mesa 20.0.8) to Fix T80141: Fix Compiling Workbench Volume Shaders (Mesa 20.0.8).Aug 28 2020, 10:12 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 28 2020, 2:01 PM