Fix T80160: Workbench shadows are broken
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Aug 28 2020, 11:32 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T80160: Workbench shadows are broken

Commits

rB3198fec1fed5: Fix T80160: Workbench shadows are broken

Summary

In recent refactoring {a9f2ebb21508} an issue was introduced that the
opengl rasterizer would be disabled when only writing to a stencil
buffer.

This fix adds stencil writing to the write mask and set it. This makes
the write map not evaluate to GPU_WRITE_NONE and the rasterizer will be
enabled in GLStateManager::set_write_mask.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Aug 28 2020, 11:32 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B9859: Diff 28259.Aug 28 2020, 11:32 AM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Aug 28 2020, 11:32 AM

Jeroen Bakker (jbakker) added projects: BF Blender (2.91), EEVEE & Viewport.

Meh, but OK, I guess. GPU_stencil_write_mask_set is a mutable state so it would not prevent the discard from happening if disabled for just a moment.

This revision is now accepted and ready to land.Aug 28 2020, 1:59 PM

Closed by commit rB3198fec1fed5: Fix T80160: Workbench shadows are broken (authored by Jeroen Bakker (jbakker)). · Explain WhyAug 28 2020, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB3198fec1fed5: Fix T80160: Workbench shadows are broken.