Page MenuHome
Differential D8748

UI: Use property split layout for add torus operator
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Aug 29 2020, 12:09 AM.

Details

Reviewers
Pablo Vazquez (pablovazquez)
Commits
rBa8cf9d2f8052: UI: Use property split layout for add torus operator
Summary

This is just an operator that I missed earlier in D8326.

I also moved the Generate UVs, Align, Location, and Rotation properties to the bottom to
be consistent with all other add mesh operators.

BeforeAfter

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) created this revision.Aug 29 2020, 12:09 AM
Harbormaster completed remote builds in B9872: Diff 28294.Aug 29 2020, 12:09 AM
Hans Goudey (HooglyBoogly) requested review of this revision.Aug 29 2020, 12:09 AM
Pablo Vazquez (pablovazquez) accepted this revision.Sep 2 2020, 5:00 PM

Nice one!

Perhaps outside the scope of this patch, but when Align is set to View or 3D Cursor, the Rotation values are ignored, maybe we shouldn't even show the sliders then?

This revision is now accepted and ready to land.Sep 2 2020, 5:00 PM
Closed by commit rBa8cf9d2f8052: UI: Use property split layout for add torus operator (authored by Hans Goudey (HooglyBoogly)). · Explain WhySep 2 2020, 5:35 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBa8cf9d2f8052: UI: Use property split layout for add torus operator.
Hans Goudey (HooglyBoogly) added a comment.Sep 2 2020, 5:36 PM
In D8748#214670, @Pablo Vazquez (pablovazquez) wrote:

Perhaps outside the scope of this patch, but when Align is set to View or 3D Cursor, the Rotation values are ignored, maybe we shouldn't even show the sliders then?

The situation there is definitely a bit odd. With the two latter options you can still change the rotation actually, then if you set align to view or cursor again it will reset it. It's probably not ideal, but keeping the rotation buttons visible does make it faster to change it if your default is view or cursor.

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Sep 3 2020, 10:20 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_operators/
53 lines

Diff 28456

View Options

release/scripts/startup/bl_operators/add_mesh_torus.py

Loading...