0004-openmp
Needs RevisionPublic
Actions

Authored by Phillip Thomas (Cambloid) on Aug 30 2020, 10:24 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Summary

This patch is not made by me, it is made by the developers of Natron VFX.

https://github.com/MrKepzie/Natron/tree/master/libs/libmv/patches

Diff Detail

Event Timeline

Phillip Thomas (Cambloid) requested review of this revision.Aug 30 2020, 10:24 PM

Phillip Thomas (Cambloid) created this revision.

Phillip Thomas (Cambloid) retitled this revision from libmv patch to 0004-openmp.Aug 30 2020, 10:32 PM

What is the measured speedup, how is it being measured?
How does this behave with track-wide threading (when different tracks are handled in different threads)? From the looks of it this will create n^2 active threads which is not acceptable.

libmv/image/image.h
29–33	Such defines belong to something more like `base/port.h`. But first of all, what is the exact need of those?
34	There can not be a single define for all type of pixel processing. This is something which is usually calculated on a per-case basis.
35	Shouldn't be dependent on Ceres.