Before, Cycles was using a shared Embree device across all instances.
This could result in crashes when viewport rendering and material
preview were using Cycles simultaneously.
Fixes issue T80042
Details
Details
- Reviewers
Brecht Van Lommel (brecht) Sergey Sharybin (sergey) - Maniphest Tasks
- T80042: Crash switching to material preview due to incorrect free with Cycles
- Commits
- rC95c087c47bb2: Separate embree device for each cpu device
rB918ef5f8352a: Cycles: Separate Embree device for each CPU Device.
rB009971ba7adc: Cycles: Separate Embree device for each CPU Device.
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- embree_separate_devices (branched from master)
- Build Status
Buildable 9918 Build 9918: arc lint + arc unit
Event Timeline
Comment Actions
The addition of Device::bvh_device() could be short lived - I would like to eventually postpone the Embree BVH build until after geometry has been synced to the device (similar to OptiX), that way Embree can share Cycles' vertex and index arrays instead of creating separate copies.
Comment Actions
From reading code and descriptions seems fine.
Please remember to run regression tests prior to commit :)