Page MenuHome

Fix T80311: Sculpt Filters not working when using vertical split
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 1 2020, 6:26 PM.

Details

Summary

All filters were using prevclicx, which is in screen coordinates and
mval[0], which is in region coordinates to get the filter strength.

This fixes the issue in all filters.

Diff Detail

Repository
rB Blender
Branch
T80311 (branched from master)
Build Status
Buildable 9924
Build 9924: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Sep 1 2020, 6:26 PM

This is more of the interface area.

From me can only comment on using const.

@Julian Eisel (Severin), please have a look or ask someone else from the interface developers :)

Yes indeed, coordinates in wmEvent are screen coordinates, with the exception of mval which is in region coordinates.

This revision is now accepted and ready to land.Sep 2 2020, 11:25 AM