Page MenuHome
Differential D8776

Fix T80311: Sculpt Filters not working when using vertical split
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 1 2020, 6:26 PM.

Details

Reviewers
Julian Eisel (Severin)
Maniphest Tasks
T80311: Cloth filter brush only works in one direction in vertically split viewport
Commits
rBfb09bc3c35b7: Fix T80311: Sculpt Filters not working when using vertical split
Summary

All filters were using prevclicx, which is in screen coordinates and
mval[0], which is in region coordinates to get the filter strength.

This fixes the issue in all filters.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 1 2020, 6:26 PM
Harbormaster completed remote builds in B9924: Diff 28419.Sep 1 2020, 6:26 PM
Pablo Dobarro (pablodp606) requested review of this revision.Sep 1 2020, 6:26 PM
Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Sep 1 2020, 6:27 PM
Sergey Sharybin (sergey) edited reviewers, added: Julian Eisel (Severin); removed: Sergey Sharybin (sergey).Sep 2 2020, 9:54 AM
Sergey Sharybin (sergey) added a subscriber: Julian Eisel (Severin).

This is more of the interface area.

From me can only comment on using const.

@Julian Eisel (Severin), please have a look or ask someone else from the interface developers :)

Julian Eisel (Severin) accepted this revision.Sep 2 2020, 11:25 AM

Yes indeed, coordinates in wmEvent are screen coordinates, with the exception of mval which is in region coordinates.

This revision is now accepted and ready to land.Sep 2 2020, 11:25 AM
Closed by commit rBfb09bc3c35b7: Fix T80311: Sculpt Filters not working when using vertical split (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 2 2020, 10:31 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBfb09bc3c35b7: Fix T80311: Sculpt Filters not working when using vertical split.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
2 lines
2 lines
2 lines

Diff 28471

View Options

source/blender/editors/sculpt_paint/sculpt_cloth.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_color.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_filter_mesh.c

Loading...