Page MenuHome
Differential D8809

Fix T80282: Playback start delayed with AV sync
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Sep 5 2020, 2:48 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T80282: Sequencer: Preview range waits for the virtual playhead to reach it's start before playing
Commits
rBf375ec4986da: Fix T80282: Playback start delayed with AV sync
Summary

If current frame is set to before start frame, with AV sync there is
delay when playback is started.

Tag scene with ID_RECALC_AUDIO_SEEK, so audio playback starts from
correct position.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Sep 5 2020, 2:48 AM
Harbormaster completed remote builds in B9994: Diff 28556.Sep 5 2020, 2:48 AM
Richard Antalik (ISS) requested review of this revision.Sep 5 2020, 2:48 AM
Sergey Sharybin (sergey) added inline comments.Sep 7 2020, 11:44 AM
source/blender/editors/screen/screen_edit.c
1525–1527

Why do you need a specific depsgraph? Why can't use general tagging DEG_id_tag_update(&scene->id, ID_RECALC_AUDIO_SEEK); be used here?

Richard Antalik (ISS) updated this revision to Diff 28636.Sep 8 2020, 12:04 AM
Richard Antalik (ISS) marked an inline comment as done.
  • Tag all depsgraphs
Harbormaster completed remote builds in B10042: Diff 28636.Sep 8 2020, 12:04 AM
Sergey Sharybin (sergey) accepted this revision.Sep 8 2020, 9:37 AM
This revision is now accepted and ready to land.Sep 8 2020, 9:37 AM
Closed by commit rBf375ec4986da: Fix T80282: Playback start delayed with AV sync (authored by Richard Antalik (ISS)). · Explain WhyOct 5 2020, 3:18 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBf375ec4986da: Fix T80282: Playback start delayed with AV sync.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
screen/
3 lines

Diff 29572

View Options

source/blender/editors/screen/screen_edit.c

Loading...