Support ASan library on macOS for all generators.
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Sep 6 2020, 1:16 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB40dcf686f04f: Support ASan library on macOS for all generators.

Summary

This change allows macOS developers to use
WITH_COMPILER_ASAN with every generator.

CMAKE_C_IMPLICIT_LINK_DIRECTORIES on macOS points to
Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/lib
which is not where the Sanitizer libraries are.

To link the library, rpath could be used but that seems complex,
so linker flags are passed as the documentation says. [1]

If users have ASAN_OPTIONS=detect_leaks=1 in their environment
variables, it should be removed to avoid a feature-unsupported error
while compiling.

[1]: http://clang.llvm.org/docs/AddressSanitizer.html#usage

Diff Detail

Repository: rB Blender

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Sep 6 2020, 1:16 PM

Ankit Meel (ankitm) created this revision.

Harbormaster completed remote builds in B10001: Diff 28570.Sep 6 2020, 1:16 PM

Fix formatting, and use find_library() itself.

Harbormaster completed remote builds in B10002: Diff 28571.Sep 6 2020, 1:27 PM

Another way to do this change was

set(CMAKE_XCODE_GENERATE_SCHEME ON)
# Uncheck some boxes so that ASan can be enabled.
set(CMAKE_XCODE_SCHEME_GUARD_MALLOC OFF)
set(CMAKE_XCODE_SCHEME_MALLOC_GUARD_EDGES OFF)
set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER ON)
set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER_USE_AFTER_RETURN ON)

But it would not be helpful for Ninja and Unix-makefiles.

CMakeLists.txt
543–547	Should `execute_process` be moved to `platform_apple.cmake` ?

Ankit Meel (ankitm) marked an inline comment as not done.Sep 6 2020, 4:17 PM

Ankit Meel (ankitm) added a reviewer: Brecht Van Lommel (brecht).Sep 6 2020, 8:18 PM

Not abuse compile flags for linker. unset variable.

Harbormaster completed remote builds in B10038: Diff 28619.Sep 7 2020, 4:58 PM

Brecht Van Lommel (brecht) accepted this revision.Sep 7 2020, 6:38 PM

This revision is now accepted and ready to land.Sep 7 2020, 6:38 PM

Ankit Meel (ankitm) retitled this revision from Enable ASan library on macOS for all generators. to Support ASan library on macOS for all generators..Sep 7 2020, 8:46 PM

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Closed by commit rB40dcf686f04f: Support ASan library on macOS for all generators. (authored by Ankit Meel (ankitm)). · Explain WhySep 7 2020, 8:49 PM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rB40dcf686f04f: Support ASan library on macOS for all generators..