Differential D8824

Fix T80531: Dope Sheet Shape Key Editor search/filter not working
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 7 2020, 11:48 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T80531: Shape Key Editor search/filter not working

Commits

rBa2921067994b: Fix T80531: Dope Sheet Shape Key Editor search/filter not working

Summary

Looks like this has just not been implemented before.
Use the name matching method used in other Dope Sheet UI modes.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 7 2020, 11:48 AM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B10020: Diff 28596.Sep 7 2020, 11:48 AM

Philipp Oeser (lichtwerk) added projects: User Interface, Animation & Rigging.Sep 7 2020, 11:48 AM

Sybren A. Stüvel (sybren) requested changes to this revision.Sep 7 2020, 11:53 AM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/editors/animation/anim_filter.c
1727	Comments should be sentences.

This revision now requires changes to proceed.Sep 7 2020, 11:53 AM

comments style

Philipp Oeser (lichtwerk) marked an inline comment as done.Sep 7 2020, 11:58 AM

Philipp Oeser (lichtwerk) added inline comments.

source/blender/editors/animation/anim_filter.c
1727	copy-paste is not always your friend :)

Sybren A. Stüvel (sybren) accepted this revision.Sep 7 2020, 12:00 PM

This revision is now accepted and ready to land.Sep 7 2020, 12:00 PM

Harbormaster completed remote builds in B10021: Diff 28597.Sep 7 2020, 12:01 PM

Closed by commit rBa2921067994b: Fix T80531: Dope Sheet Shape Key Editor search/filter not working (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 7 2020, 12:04 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) marked an inline comment as done.

Philipp Oeser (lichtwerk) added a commit: rBa2921067994b: Fix T80531: Dope Sheet Shape Key Editor search/filter not working.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

anim_filter.c

7 lines

Diff 28598

View Options

source/blender/editors/animation/anim_filter.c

Fix T80531: Dope Sheet Shape Key Editor search/filter not workingClosedPublicActions