Paths

Table of Contentst

Differential D8835

Fix T79737:ERROR ACCESS VIOLATION when switching to evee rendered view
ClosedPublic
Actions

Authored by Aristotelis Dossas (teldosas) on Sep 8 2020, 6:50 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Richard Antalik (ISS)

Maniphest Tasks

T79737: ERROR ACCESS VIOLATION when switching to evee rendered view

Commits

rB3be5697b889a: Fix T79737: ERROR ACCESS VIOLATION when switching to eevee rendered view
rB4a82d792b03b: Fix T79737: ERROR ACCESS VIOLATION when switching to eevee rendered view

Summary

This prevents Blender from crashing when switching
to rendered view and the grid_data is NULL in the
lightcache (due to possible corruption), by switching
to the fallback lightcache. The fix extends the solution
for possible corruption in the cube_data as well.

Diff Detail

Repository: rB Blender

Event Timeline

Aristotelis Dossas (teldosas) requested review of this revision.Sep 8 2020, 6:50 PM

Aristotelis Dossas (teldosas) created this revision.

Harbormaster completed remote builds in B10060: Diff 28660.Sep 8 2020, 6:50 PM

Aristotelis Dossas (teldosas) edited the summary of this revision. (Show Details)Sep 8 2020, 6:52 PM

I don't have knowledge to really review this, but I can confirm that it resovles the crash.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Sep 9 2020, 5:12 PM

Ankit Meel (ankitm) added a task: T79737: ERROR ACCESS VIOLATION when switching to evee rendered view.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Clément Foucault (fclem) accepted this revision.Sep 9 2020, 5:17 PM

This revision is now accepted and ready to land.Sep 9 2020, 5:17 PM

Closed by commit rB4a82d792b03b: Fix T79737: ERROR ACCESS VIOLATION when switching to eevee rendered view (authored by Aristotelis Dossas (teldosas), committed by Clément Foucault (fclem)). · Explain WhySep 10 2020, 2:34 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB4a82d792b03b: Fix T79737: ERROR ACCESS VIOLATION when switching to eevee rendered view.

Jeroen Bakker (jbakker) added a commit: rB3be5697b889a: Fix T79737: ERROR ACCESS VIOLATION when switching to eevee rendered view.Sep 16 2020, 2:41 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

eevee_lightcache.c

4 lines

Diff 28730

source/blender/draw/engines/eevee/eevee_lightcache.c

Loading...