Fix T80424: Image not scaled when rendering
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Sep 8 2020, 11:48 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T80424: Picture-Offset in downsized Animation-Render not Working

Commits

rB0d7036b40e68: Fix T80424: Image not scaled when rendering

Summary

This is was caused by incorrectly set preview_render_size in VSE
rendering context. Value was set to SEQ_PROXY_RENDER_SIZE_FULL, but
it should be SEQ_PROXY_RENDER_SIZE_SCENE as scene render size is
being used.

Alternatively we can check for context->for_render in
input_preprocess(), but I think fix above is more correct.

Diff Detail

Repository

rB Blender

Branch

T80424 (branched from master)

Build Status

Buildable 10065
Build 10065: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Sep 8 2020, 11:48 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B10065: Diff 28666.Sep 8 2020, 11:48 PM

To me it seems a bit confusing to use proxy size. It might be OK, but would be nice to know what exactly caused the bug to appear (the report says it worked fine in 2.81). Did you check what change have caused the issue?

In D8838#216361, @Sergey Sharybin (sergey) wrote:

To me it seems a bit confusing to use proxy size. It might be OK, but would be nice to know what exactly caused the bug to appear (the report says it worked fine in 2.81). Did you check what change have caused the issue?

It is regression from 2.83 caused by rB537292498324 as I suspected. It did not work before commit with proxies because preview size was literaly guessed. Now only render is broken, that's why I made change in pipeline.c.
I can see why this is a bit confusing, so I wil rename enum in D8861.