Page MenuHome
Differential D8839

Fix T78823: Slash in custom property name does not work
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Sep 8 2020, 11:48 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Bastien Montagne (mont29)
Maniphest Tasks
T78823: Slash in custom property name does not work
Commits
rBcbae82ba960a: Fix T78823: Slash in custom property name does not work
Summary

Some characters: ', ", and \ can cause problems with RNA paths.
Instead of using more complicated handling to deal with those cases,
we can just prevent these characters from being used in custom property
names.

I'm not sure that this is the right place to do this check, or if it's the right
place to store the set of forbidden characters-- it seems maybe a bit too
localized? But it's also quite simple, which is nice.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 8 2020, 11:48 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B10066: Diff 28667.Sep 8 2020, 11:48 PM
Hans Goudey (HooglyBoogly) added a task: T78823: Slash in custom property name does not work.Sep 8 2020, 11:48 PM
Jacques Lucke (JacquesLucke) added a comment.Sep 9 2020, 10:23 AM

I think it might make more sense to do this check in idp_try_read_name. We do other validity checking there as well.

Hans Goudey (HooglyBoogly) updated this revision to Diff 28685.Sep 9 2020, 4:00 PM
  • Move check to idp_try_read_name

How is this?

Harbormaster completed remote builds in B10078: Diff 28685.Sep 9 2020, 4:00 PM
Jacques Lucke (JacquesLucke) added a subscriber: Campbell Barton (campbellbarton).Sep 9 2020, 4:08 PM

LGTM, but better wait for the opinion of @Bastien Montagne (mont29) or @Campbell Barton (campbellbarton).

This new restriction should be documented in the release notes.

Jacques Lucke (JacquesLucke) accepted this revision.Sep 9 2020, 4:08 PM
This revision is now accepted and ready to land.Sep 9 2020, 4:08 PM
Hans Goudey (HooglyBoogly) added a comment.Sep 21 2020, 6:27 PM

@Bastien Montagne (mont29) How does this look to you?

Bastien Montagne (mont29) accepted this revision.Sep 22 2020, 9:00 AM

LGTM.

Closed by commit rBcbae82ba960a: Fix T78823: Slash in custom property name does not work (authored by Hans Goudey (HooglyBoogly)). · Explain WhySep 22 2020, 3:50 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBcbae82ba960a: Fix T78823: Slash in custom property name does not work.
Campbell Barton (campbellbarton) added a reverting change: rBd1cedf53faaf: Revert "Fix T78823: Slash in custom property name does not work".Dec 9 2020, 5:30 AM
Jeroen Bakker (jbakker) added a reverting change: rBceac8559e105: Revert "Fix T78823: Slash in custom property name does not work".Jan 13 2021, 3:10 PM

Revision Contents
Changeset List

PathSize
source/
blender/
python/
generic/
7 lines

Diff 29173

View Options

source/blender/python/generic/idprop_py_api.c

Loading...