Details

Reviewers

Maniphest Tasks

T80127: No slash in «Bright Contrast» menu item

Summary

This patch changes the few places we use "Bright" to stand for "Brightness" in the UI and also changes the node UI names from "Bright/Contrast" or
"Bright Contrast" to a consistent "Brightness/Contrast"

And here's a reminder to myself to change "Bright Contrast" in the node wrangler addon later too.

Diff Detail

Repository

rB Blender

Branch

fix-bright-contrast-consistent-name (branched from master)

Build Status

Buildable 10069
Build 10069: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 9 2020, 12:45 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B10069: Diff 28670.Sep 9 2020, 12:45 AM

Missed one

Harbormaster completed remote builds in B10070: Diff 28671.Sep 9 2020, 12:46 AM

Hans Goudey (HooglyBoogly) added inline comments.Sep 9 2020, 12:51 AM

intern/cycles/render/nodes.cpp
5135–5157	I'm not sure if these changes are necessary too, but at least the patch can start out consistent.

Hans Goudey (HooglyBoogly) added a task: T80127: No slash in «Bright Contrast» menu item.Sep 9 2020, 12:51 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Sep 9 2020, 12:54 AM

Looks like I might need to test to see whether this needs versioning

Yevgeny Makarov (jenkm) awarded a token.Sep 9 2020, 8:53 AM

It indeed needs versioning.

Merge branch 'master' into fix-bright-contrast-consistent-name
Add versioning

@Aaron Carlisle (Blendify) You should be able to use this same versioning code to update D6787.

Harbormaster completed remote builds in B10767: Diff 30036.Oct 17 2020, 2:26 AM

@Hans Goudey (HooglyBoogly) - your versioning code doesn't seem to work for me. Can you double-check?

test-bright-contrast.blend135 KBDownload

Hans Goudey (HooglyBoogly) added a project: User Interface.Nov 2 2020, 11:40 PM

Merge branch 'master' into fix-bright-contrast-consistent-name
Add versioning for socket default values

@Yevgeny Makarov (jenkm) Thanks! I forgot to add versioning for socket default values for when there are no links.

Harbormaster completed remote builds in B11065: Diff 30641.Nov 3 2020, 12:00 AM

Merge branch 'master' into fix-bright-contrast-consistent-name
Use recently added node socket rename utility function

Harbormaster completed remote builds in B12406: Diff 33193.Jan 27 2021, 5:47 AM

Yevgeny Makarov (jenkm) mentioned this in D11602: Fix a typo.Oct 27 2021, 2:06 PM

I'll merge master into this patch.

Brecht Van Lommel (brecht) mentioned this in D13359: Rename "fac" to "factor" across all nodes.Nov 25 2021, 9:43 PM

UI: Use consistent "Brightness" term, fix T80127
Changes PlannedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28670

intern/cycles/render/nodes.cpp

source/blender/blenkernel/intern/seqmodifier.c

source/blender/makesrna/intern/rna_sequencer.c

source/blender/nodes/NOD_static_types.h

source/blender/nodes/composite/nodes/node_composite_brightness.c

source/blender/nodes/shader/nodes/node_shader_brightness.c

UI: Use consistent "Brightness" term, fix T80127Changes PlannedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28670

intern/cycles/render/nodes.cpp

source/blender/blenkernel/intern/seqmodifier.c

source/blender/makesrna/intern/rna_sequencer.c

source/blender/nodes/NOD_static_types.h

source/blender/nodes/composite/nodes/node_composite_brightness.c

source/blender/nodes/shader/nodes/node_shader_brightness.c

UI: Use consistent "Brightness" term, fix T80127
Changes PlannedPublic
Actions

Revision Contents
Changeset List