Cleanup: de-duplicate code for instancing objects when linking
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Sep 9 2020, 6:56 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Bastien Montagne (mont29)

Summary

This de-duplicates operations on an objects base when instantiating objects created when linking.

This is a follow up to D8792, Sybren suggested to de-duplicate the logic.

I don't have a strong opinion on this as it's only wrapping two function calls and some optional assignments. OTOH it has the advantage that all Base operations are handled in one place.

Diff Detail

Repository

rB Blender

Branch

TEMP-CLEANUP-LINKING (branched from master)

Build Status

Buildable 10072
Build 10072: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Sep 9 2020, 6:56 AM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B10071: Diff 28672.Sep 9 2020, 6:56 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 9 2020, 7:00 AM

Campbell Barton (campbellbarton) added a reviewer: Sybren A. Stüvel (sybren).

Campbell Barton (campbellbarton) added projects: BF Blender, Pipeline, Assets & I/O.

Add comment regarding inconsistency with setting object active.

Harbormaster completed remote builds in B10072: Diff 28673.Sep 9 2020, 7:04 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 9 2020, 7:08 AM

Campbell Barton (campbellbarton) mentioned this in D8792: Library Linking: support instantiating object data on append/link.Sep 9 2020, 7:12 AM

LGTM, always better to factorize logic, even if only for a few lines of code.

source/blender/blenloader/intern/readfile.c
10341	This does not seem to be related to the purpose of this patch? Is it actually needed, and why?

This revision is now accepted and ready to land.Sep 22 2020, 2:01 PM

Campbell Barton (campbellbarton) mentioned this in rBa51455918cb9: Cleanup: de-duplicate code for instancing objects when linking.Nov 6 2020, 5:02 AM

Committed rBa51455918cb9: Cleanup: de-duplicate code for instancing objects when linking

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

readfile.c

77 lines

Diff 28673

View Options

source/blender/blenloader/intern/readfile.c

Cleanup: de-duplicate code for instancing objects when linkingClosedPublicActions