The code to handle object transforms was wrong. Now the trimming mesh
and depts is calculated in world space, using the real view origin and
normal and then stored in object space in the mesh and in the original
coordinates array. As now both meshes for the boolean operation are in
the same object space, the space conversion code can also be removed
from the boolean function.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/editors/sculpt_paint/paint_mask.c | ||
|---|---|---|
| 289 |
so these (variables?) are not a true version of them ? What is the true version anyway? | |
| source/blender/editors/sculpt_paint/paint_mask.c | ||
|---|---|---|
| 289 | This is how variables are named all over the sculpt code. When a variable needs to be modified for symmetry, the original version has the true prefix and never changes and there is another variable with the same name without the prefix that changes per symmetry pass. | |
| source/blender/editors/sculpt_paint/paint_mask.c | ||
|---|---|---|
| 289 | Ok, this is fine. | |
| source/blender/editors/sculpt_paint/paint_mask.c | ||
|---|---|---|
| 289 | ||
Comment Actions
@Bastien Montagne (mont29) The code was already reviewed, I just updated the comment in the latest update
Comment Actions
@Pablo Dobarro (pablodp606) Unless getting this in master is really urgent, I would rather let @Sergey Sharybin (sergey) finish the review? More efficient this way imho (and less risk of missing something in the review process).
Comment Actions
Not very urgent right now as the tools is in experimental because of the missing icons, but it would be nice to have this committed before enabling it by default as it is a very obvious bug and it is going to produce a lot of reports