Page MenuHome

Property Search: Move properties context buttons back to a panel
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Sep 9 2020, 6:57 PM.

Details

Summary

The context path buttons used to be in a panel in 2.79. Although they look
a bit better in the header, there is not space for them with the property
search field in the header as well.

In the long term, maybe it will be possible to shrink the text button and
then animate it expanding when property search begins, then there
would be enough room for both.

Note that this diff is just for review, Blender won't ever actually have only
the pin button in the header like the following image.

Diff Detail

Repository
rB Blender
Branch
property-search-move-context-to-panel (branched from master)
Build Status
Buildable 10175
Build 10175: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 9 2020, 6:57 PM

Diff from the previous patch

This revision is now accepted and ready to land.Sep 10 2020, 12:23 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Sep 10 2020, 2:15 PM
  • Merge branch 'property-search-button-label-pointer' into property-search-move-context-to-panel
Julian Eisel (Severin) requested changes to this revision.Sep 15 2020, 12:03 PM

I wasn't sure at first, but after testing I think the pin icon should be kept next to the data path. Ideally right-aligned. This was also part of the initial design in T71185.

This revision now requires changes to proceed.Sep 15 2020, 12:03 PM

Right, I can do that when committing. The single-tab patch adds two separators so the pin icon ends up on the right anyway.

Alright, all good then.

This revision is now accepted and ready to land.Sep 15 2020, 3:40 PM
  • Property Search: Add separator_spacer to context panel patch