Differential D8854

Property Search: Add "Search match" theme color
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Sep 9 2020, 7:08 PM.

Tags

Subscribers

Julian Eisel (Severin)

Details

Reviewers

Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Group Reviewers

Maniphest Tasks

T77824: Properties Search Implementation

Commits

rBf59ce4d55c04: Property Search: Add "search match" theme color

Summary

D8376, D8783, D8853, >>D8854<<, D8856, D8857, D8858, D8859

We use a highlight on panel headers to convey that they have a search match.
It's also conceivable to use this color to highlight the property editor tabs
that have search results.

Normally we don't like adding new theme colors, but this is quite a special
case. For example, the color in the outliner is green. This patch has a blue
highlight so it feels more cohesive though.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 9 2020, 7:08 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B10087: Diff 28700.Sep 9 2020, 7:08 PM

Hans Goudey (HooglyBoogly) added a reviewer: User Interface.Sep 9 2020, 7:09 PM

Hans Goudey (HooglyBoogly) added projects: User Interface, BF Blender (2.91).

Hans Goudey (HooglyBoogly) added a parent revision: D8853: Property Search: Move properties context buttons back to a panel.

Trying to get arc to show the difference from D8853

Harbormaster completed remote builds in B10088: Diff 28701.Sep 9 2020, 7:15 PM

Another try

Harbormaster completed remote builds in B10089: Diff 28702.Sep 9 2020, 7:17 PM

I'd suggest to bump subversion for the commit. LGTM.

This revision is now accepted and ready to land.Sep 9 2020, 7:37 PM

Hans Goudey (HooglyBoogly) added a child revision: D8856: Property Search: Single tab.Sep 9 2020, 8:02 PM

Hans Goudey (HooglyBoogly) mentioned this in D8859: Property Search: All tabs.Sep 9 2020, 8:50 PM

Hans Goudey (HooglyBoogly) mentioned this in D8858: Property Search: Add highlight arguments to tab buttons.

Hans Goudey (HooglyBoogly) mentioned this in D8857: Property Search: Quick start and clear operators.

Hans Goudey (HooglyBoogly) mentioned this in D8856: Property Search: Single tab.

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Sep 9 2020, 8:54 PM

Hans Goudey (HooglyBoogly) mentioned this in D8853: Property Search: Move properties context buttons back to a panel.

Hans Goudey (HooglyBoogly) mentioned this in D8783: Property Search: Search with button groups.

Hans Goudey (HooglyBoogly) mentioned this in D8376: Property Search: Use an operator to set the property editor's pinned data-block.

Hans Goudey (HooglyBoogly) added a task: T77824: Properties Search Implementation.Sep 9 2020, 8:57 PM

Campbell Barton (campbellbarton) accepted this revision.Sep 10 2020, 12:23 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Sep 10 2020, 2:18 PM

Merge branch 'property-search-move-context-to-panel' into property-search-add-theme-color

Harbormaster completed remote builds in B10176: Diff 28835.Sep 14 2020, 5:11 PM

Closed by commit rBf59ce4d55c04: Property Search: Add "search match" theme color (authored by Hans Goudey (HooglyBoogly)). · Explain WhySep 15 2020, 5:35 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBf59ce4d55c04: Property Search: Add "search match" theme color.

Revision Contents
Changeset List

Path

Size

release/

datafiles/

userdef/

userdef_default_theme.c

1 line

scripts/

presets/

interface_theme/

blender_light.xml

4 lines

source/

blender/

blenloader/

intern/

versioning_userdef.c

2 lines

makesrna/

intern/

7 lines

Diff 28886

release/datafiles/userdef/userdef_default_theme.c

Loading...

release/scripts/presets/interface_theme/blender_light.xml

Loading...

source/blender/blenloader/intern/versioning_userdef.c

Loading...

source/blender/makesrna/intern/rna_userdef.c

Loading...