Page MenuHome

Property Search: Add highlight arguments to tab buttons
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Sep 9 2020, 8:27 PM.

Details

Summary

For searching multiple tabs, we need a way to show which tabs have a search
result, but we still need to be able to show which tab is active. Also, multiple
tabs can be highlighted, so that argument needs be be a bitfield enum. This
requires giving extra arguments to ui_item_enum_expand_tabs.

Unforunately this adds a bit of ugly complexity to this function. It would be
better if RNA enum items could have an "active" flag, but that change would
probably have larger scope.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 9 2020, 8:27 PM
Hans Goudey (HooglyBoogly) created this revision.
This revision is now accepted and ready to land.Sep 10 2020, 1:01 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Sep 10 2020, 2:17 PM
  • Merge branch 'property-search-start-end-operators' into property-search-highlight-tabs
  • Merge branch 'master' into property-search-highlight-tabs

Use boolean array instead of bitfield enum for highlighting tabs