Page MenuHome
Differential D8890

UV/Image Editor: Overlay Popover
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Sep 14 2020, 3:16 PM.

Details

Reviewers
Julian Eisel (Severin)
Pablo Vazquez (pablovazquez)
Group Reviewers
User Interface
Maniphest Tasks
T80767: UV Image Editor: Overlay Popover
Commits
rBafab33e0b97c: UV/Image Editor: Overlay Popover
Summary

The overlay options in the image/uv editor is hidden in side panels and menus. Sometimes this panel is even hidden, while still useful.
The goal of this task is to introduce an overlay pop-over just like the overlay-popover of the 3d viewport.

Popover has

  • UV Stretching (only available in the UV mode, when active object mode is a mesh and in OB_EDIT mode)
  • Display As (only available in the UV mode, when active object mode is a mesh and in OB_EDIT mode)
  • Show Modified (only available in the UV mode, when active object mode is a mesh and in OB_EDIT mode)
  • Show UV Edges (including opacity slider; available UV, View, Paint, when active object mode is a mesh and in OB_EDIT mode)
  • Udim tiles when no image is available.

Like the 3d viewport, there will be a editor toggle to enable/disable the overlays

For compatibility reasons the RNA properties are added to both the SpaceImage.uv_editor amd SpaceImage.overlay. On DNA level they are still stored in the SpaceImage. only new properties are added to the SpaceImageOverlay struct. During the next major release we could remove these options from SpaceImage.uv_editor. This should be noted in the Python section of release notes.

See T80767: UV Image Editor: Overlay Popover

Diff Detail

Repository
rB Blender
Branch
uvimage-popover (branched from master)
Build Status
Buildable 10428
Build 10428: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Sep 14 2020, 3:16 PM
Jeroen Bakker (jbakker) created this revision.
Harbormaster completed remote builds in B10172: Diff 28830.Sep 14 2020, 3:16 PM
Jeroen Bakker (jbakker) added a task: T80767: UV Image Editor: Overlay Popover.Sep 14 2020, 3:17 PM
Jeroen Bakker (jbakker) added inline comments.Sep 14 2020, 3:19 PM
source/blender/makesdna/DNA_space_types.h
1168

Revert changes in this line

source/blender/makesrna/intern/rna_space.c
4550

Add other properties here, but keep the original properties for script compatibility.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 14 2020, 3:25 PM
Jeroen Bakker (jbakker) added inline comments.Sep 14 2020, 3:55 PM
release/scripts/startup/bl_ui/space_image.py
1469

Feedback is that the popover is to wide. Perhaps we should remove this line as it was copied from the 3d view

Jeroen Bakker (jbakker) added inline comments.Sep 15 2020, 9:44 AM
source/blender/makesdna/DNA_space_types.h
1042

We might want to move the other overlay options here.
Make sure the old RNA maps to this struct. This adds breakage opening b291 files on older files but that is only cosmetic.

Jeroen Bakker (jbakker) updated this revision to Diff 28932.Sep 16 2020, 1:24 PM
  • Make the popup panel smaller
  • Reverted unneeded change
  • RNA migration draw options to SpaceImageOverlay
  • Moved UDIM grid to overlay
Harbormaster completed remote builds in B10235: Diff 28932.Sep 16 2020, 1:24 PM
Jeroen Bakker (jbakker) added inline comments.Sep 16 2020, 1:26 PM
source/blender/makesdna/DNA_space_types.h
1042

Moving other options breaks older files, so we should move them during the next major release (3.0). Any new options can directly be added.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 16 2020, 1:27 PM
Jeroen Bakker (jbakker) added a reviewer: User Interface.
Jeroen Bakker (jbakker) added projects: BF Blender (2.91), Restricted Project.
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 16 2020, 1:30 PM
Julian Eisel (Severin) added a project: User Interface.Sep 16 2020, 4:24 PM
Pieter Schiettecatte (Schiette) awarded a token.Sep 17 2020, 9:27 PM
Pieter Schiettecatte (Schiette) rescinded a token.
Pieter Schiettecatte (Schiette) awarded a token.Sep 17 2020, 9:34 PM
Pieter Schiettecatte (Schiette) added a subscriber: Pieter Schiettecatte (Schiette).
Jeroen Bakker (jbakker) updated this revision to Diff 29022.Sep 18 2020, 11:54 AM
  • Hide meta data and sample line when overlays are disabled
Harbormaster completed remote builds in B10289: Diff 29022.Sep 18 2020, 11:54 AM
Jeroen Bakker (jbakker) updated this revision to Diff 29041.Sep 18 2020, 4:34 PM
  • Hide meta data and sample line when overlays are disabled
  • Tweaked UI labels
Harbormaster completed remote builds in B10299: Diff 29041.Sep 18 2020, 4:34 PM
Yuichiro Fujita (chironamo) awarded a token.Sep 22 2020, 10:09 PM
Julian Eisel (Severin) requested changes to this revision.Sep 28 2020, 11:32 AM
Julian Eisel (Severin) added a reviewer: Pablo Vazquez (pablovazquez).
Julian Eisel (Severin) added subscribers: Hans Goudey (HooglyBoogly), Pablo Vazquez (pablovazquez), Julian Eisel (Severin).

Straightforward patch, so I'm mostly commenting on tooltips. Design wise this seems also good to me, but I want @Pablo Vazquez (pablovazquez) to sign off as well.

source/blender/makesdna/DNA_space_types.h
1042

Can we somehow make sure that we remember this during 3.0? Maybe we should already create the project/workboard for it.

source/blender/makesrna/intern/rna_space.c
2993

You only copied this, but this description sounds weird. The "also" feels incorect. @Hans Goudey (HooglyBoogly), we need a native speaker here.

4549

The 3D View tooltip says "Display overlays like gizmos and outlines". Maybe use something similar here?

4721

UV/image -> UV/Image.

This revision now requires changes to proceed.Sep 28 2020, 11:32 AM
Jeroen Bakker (jbakker) updated this revision to Diff 29319.Sep 28 2020, 12:13 PM
Jeroen Bakker (jbakker) marked 2 inline comments as done.
  • UV/Image: Updated Popover Help Text
Harbormaster completed remote builds in B10428: Diff 29319.Sep 28 2020, 12:13 PM
Jeroen Bakker (jbakker) mentioned this in T81287: Remove Overlay options from SpaceImage.uvedit.Sep 29 2020, 10:26 AM
Jeroen Bakker (jbakker) marked an inline comment as done.
Jeroen Bakker (jbakker) added inline comments.
source/blender/makesdna/DNA_space_types.h
1042

T81287: Remove Overlay options from SpaceImage.uvedit

source/blender/makesrna/intern/rna_space.c
2993

Hmmm... Automatically select UVs sharing the same vertex as the ones being selected matches the functionality.

4549

I selected UV Maps and Metadata. These are the common options between the different editor modes.

Julian Eisel (Severin) accepted this revision as: Julian Eisel (Severin).Sep 29 2020, 11:55 AM
Hans Goudey (HooglyBoogly) added inline comments.Sep 29 2020, 6:13 PM
source/blender/makesrna/intern/rna_space.c
2993

Hmm, looks like this isn't part of the patch anymore, but yeah, "also" definitely isn't right.
And I have some other problems with this description too, so I split this to a new patch: D9049

Jeroen Bakker (jbakker) marked 3 inline comments as done.Sep 30 2020, 8:38 AM
Pablo Vazquez (pablovazquez) added a comment.EditedOct 6 2020, 8:51 PM

Screenshot of the current patch for context:

In Edit Mode, I'm not sure we really need to split into Edges and Faces section (unless there are plans to add new component-specific features here soon?)

Reasons
  • Makes the title section Faces and the checkbox Faces feel redundant.
  • Display Stretch turned on makes Faces be grayed out even though it's underneath, feels weird.
  • UV Opacity does not affect Display Stretch, so it shouldn't be on top.
Proposal
  • Move Display Stretch to the top, since it's not affected by the other properties.
  • Merge Edges and Faces panels into a Geometry panel (matches 3D Viewport's)
  • The new Geometry panel contains:
    • Opacity
    • Faces
    • Edge Display
    • Modified Edges

What do you think?

Another small note, in Paint mode there's some extra space at the top:

Outside the scope of this patch, but as a reminder note for later, we need the equivalent of hiding navigation/gizmos in this editor as well (show_gizmo in 3D Viewport).

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Oct 6 2020, 9:23 PM
Jeroen Bakker (jbakker) added a comment.Oct 7 2020, 3:08 PM

@Pablo Vazquez (pablovazquez) Thanks for the feedback.

The only issue I have is moving the stretching overlay to the top. Stretching isn't used that often and was also hidden in subpanels in the current design. Moving it to the top makes the mouse movement/eye scanning a bit strange (UX).
I can see your point and don't have a good solution for it. But we could start with a clean design (your proposal) and iterate over it with user feedback.

Jeroen Bakker (jbakker) updated this revision to Diff 29696.Oct 7 2020, 5:03 PM

UI layout changes

Jeroen Bakker (jbakker) added a comment.Oct 7 2020, 5:04 PM

Finally I switched edges and faces as it is easier for the eye.

The empty space is the header of the panel.

Harbormaster completed remote builds in B10608: Diff 29696.Oct 7 2020, 5:05 PM
Pablo Vazquez (pablovazquez) accepted this revision.Oct 7 2020, 5:07 PM

Much nicer, thanks!

This revision is now accepted and ready to land.Oct 7 2020, 5:07 PM
Closed by commit rBafab33e0b97c: UV/Image Editor: Overlay Popover (authored by Jeroen Bakker (jbakker)). · Explain WhyOct 7 2020, 5:16 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rBafab33e0b97c: UV/Image Editor: Overlay Popover.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
208 lines
source/
blender/
blenloader/
intern/
14 lines
draw/
engines/
overlay/
42 lines
1 line
1 line
intern/
11 lines
editors/
space_image/
1 line
makesdna/
13 lines
makesrna/
1 line
intern/
36 lines

Diff 29319

View Options

release/scripts/startup/bl_ui/space_image.py

Loading...
View Options

source/blender/blenloader/intern/versioning_290.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_edit_uv.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_engine.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_private.h

Loading...
View Options

source/blender/draw/intern/draw_view.c

Loading...
View Options

source/blender/editors/space_image/space_image.c

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...