Page MenuHome
Differential D8895

Dont show temporary IK constraints in the constraint stack
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 14 2020, 11:29 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T80437: Auto IK Double Generates IK constraints
Commits
rB7a0a60dde8b4: Dont show temporary IK constraints in the constraint stack
Summary

Those constraints are added when using AutoIK (or targetless IK as
well).
While not strictly incorrect, these kinds of constraints were not
showing in the UI prior to rBeaa44afe703e (and I think they should not).

ref T80437

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 14 2020, 11:29 PM
Harbormaster completed remote builds in B10189: Diff 28854.Sep 14 2020, 11:29 PM
Philipp Oeser (lichtwerk) requested review of this revision.Sep 14 2020, 11:29 PM
Philipp Oeser (lichtwerk) mentioned this in T80437: Auto IK Double Generates IK constraints.Sep 14 2020, 11:32 PM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.
Philipp Oeser (lichtwerk) added reviewers: Hans Goudey (HooglyBoogly), Sybren A. Stüvel (sybren).
Hans Goudey (HooglyBoogly) accepted this revision.Sep 15 2020, 1:08 AM

Thanks for looking into this. I always enjoy your deep dives into the causes of bugs and this one is no exception. I'll try not to be the source of them though : P

Accepting with just one caveat inline.

source/blender/editors/interface/interface_templates.c
2105

It worked fine for me when I tested this patch, but theoretically this check should be duplicated down here too). I'm guessing it works because they're added at the end.
Otherwise it might break in the case where the constraint list doesn't change over successive redraws.

Sorry for the messiness of this code. It's in my personal medium terms to clean up / generalize the code for the different stacks.
This check would become a generalized "don't show data in UI" check.
So let's keep this consistent with the other templates and add the check down here for now too.

This revision is now accepted and ready to land.Sep 15 2020, 1:08 AM
Closed by commit rB7a0a60dde8b4: Dont show temporary IK constraints in the constraint stack (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 15 2020, 6:02 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB7a0a60dde8b4: Dont show temporary IK constraints in the constraint stack.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
16 lines

Diff 28890

View Options

source/blender/editors/interface/interface_templates.c

Loading...