Sculpt: Preserve Mesh visibility from edit mode using the Face Sets
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 16 2020, 12:51 AM.

Details

Reviewers

Commits

rB53804b333a1f: Sculpt: Preserve Mesh visibility from edit mode using the Face Sets

Summary

Before this change, when users switch from edit mode to sculpt mode, the
entire mesh would be visible. Even if in the edit mesh mode part of it was
set to invisible.

With this change the visibility is preserved, by creating a separate face set
for the visible and invisible parts of the mesh and setting their initial visibility.

Implementation details: This adds a function to initialize a new Face Set
datalayer taking the current mesh visibility into account which is stored
in the ME_HIDE flag of the vertices.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 16 2020, 12:51 AM

Harbormaster completed remote builds in B10223: Diff 28916.Sep 16 2020, 12:51 AM

Pablo Dobarro (pablodp606) requested review of this revision.Sep 16 2020, 12:51 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Sep 16 2020, 12:52 AM

Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Create new Face Sets datalayer using mesh visibility to Sculpt: Ensure Face Sets datalayer from base mesh visibility.

Please rephrase the description in a way which explains user-level change of behavior. Is it a fix? Is it some other sort of improvement? What exactly does this mean?

source/blender/blenkernel/intern/paint.c
1888	Remove underscore?

Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Ensure Face Sets datalayer from base mesh visibility to Sculpt: Preserve Mesh visibility from edit mode using the Face Sets.Sep 18 2020, 1:25 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)

remove underscore

Harbormaster completed remote builds in B10284: Diff 29011.Sep 18 2020, 1:26 AM

Suggested summary:
"
Before this change, when users switch from edit mode to sculpt mode, the entire mesh would be visible. Even if in the edit mesh mode part of it was set to invisible.

With this change the visibility is preserved, by creating a separate face set for the visible and invisible parts of the mesh and setting their initial visibility.

Implementation details: This adds a function to initialize a new Face Set datalayer taking the current mesh visibility into account which is stored in the ME_HIDE flag of the vertices.
"

I personally would even go as far as not mentioning the implementation details in this case. But either way I recommend to always start the commit log with the changes from the user level. Please see: https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Features

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Sep 28 2020, 10:55 PM

Sergey Sharybin (sergey) accepted this revision.Sep 29 2020, 10:09 AM

This revision is now accepted and ready to land.Sep 29 2020, 10:09 AM

Closed by commit rB53804b333a1f: Sculpt: Preserve Mesh visibility from edit mode using the Face Sets (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 29 2020, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB53804b333a1f: Sculpt: Preserve Mesh visibility from edit mode using the Face Sets.