Page MenuHome
Differential D890

Fix T41783: Cycles baking ignores displacement
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Nov 11 2014, 5:22 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T41783: Cycles baking ignores displacement
Commits
rBS8c227adb8cf8: Fix T41783: Cycles baking ignores displacement
rCabfa1a489699: Fix T41783: Cycles baking ignores displacement
rB8c227adb8cf8: Fix T41783: Cycles baking ignores displacement
Summary
  • Fix T41783: Cycles baking ignores displacement
  • Create unique flag for output shaders with displacement data

Diff Detail

Repository
rB Blender
Branch
bake-normal

Event Timeline

Dalai Felinto (dfelinto) updated this revision to Diff 2860.Nov 11 2014, 5:22 PM
Dalai Felinto (dfelinto) retitled this revision from to Fix T41783: Cycles baking ignores displacement.
Dalai Felinto (dfelinto) added a reviewer: Brecht Van Lommel (brecht).
Dalai Felinto (dfelinto) updated this object.
Dalai Felinto (dfelinto) mentioned this in T41783: Cycles baking ignores displacement.Nov 11 2014, 5:23 PM
Dalai Felinto (dfelinto) updated this object.
Dalai Felinto (dfelinto) added a project: Cycles.
Dalai Felinto (dfelinto) added a task: T41783: Cycles baking ignores displacement.
Brecht Van Lommel (brecht) added inline comments.Nov 11 2014, 6:04 PM
intern/cycles/kernel/kernel_types.h
620

This overlaps with SD_HOLDOUT_MASK now, you need to increment all the object flags below.

Dalai Felinto (dfelinto) updated this revision to Diff 2863.Nov 11 2014, 6:48 PM
  • fixing an oversight - bumping the flags value
Brecht Van Lommel (brecht) accepted this revision.Nov 11 2014, 6:57 PM
Brecht Van Lommel (brecht) edited edge metadata.
This revision is now accepted and ready to land.Nov 11 2014, 6:57 PM
Closed by commit rB8c227adb8cf8: Fix T41783: Cycles baking ignores displacement (authored by Dalai Felinto (dfelinto)). · Explain WhyNov 11 2014, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
4 lines
3 lines
render/
2 lines

Diff 2860

View Options

intern/cycles/kernel/kernel_bake.h

Loading...
View Options

intern/cycles/kernel/kernel_types.h

Loading...
View Options

intern/cycles/render/shader.cpp

Loading...