Page MenuHome
Differential D8922

macOS: Added potrace in platform apple cmake
ClosedPublic
Actions

Authored by Sebastián Barschkis (sebbas) on Sep 17 2020, 3:40 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T80818: Deps: potrace 1.16
Commits
rB08a3f01ddcd4: macOS: Added potrace in platform apple cmake
Summary

Ref T80818

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 10264
Build 10264: arc lint + arc unit

Event Timeline

Sebastián Barschkis (sebbas) requested review of this revision.Sep 17 2020, 3:40 PM
Sebastián Barschkis (sebbas) created this revision.
Harbormaster completed remote builds in B10264: Diff 28975.Sep 17 2020, 3:40 PM
Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).Sep 17 2020, 3:48 PM
Ankit Meel (ankitm) added inline comments.
build_files/cmake/platform/platform_apple.cmake
420

platform_apple.cmake:29

macro(find_package_wrapper)
# do nothing, just satisfy the macro
endmacro()

It should be find_package(POTRACE) AFAIK. Lower case would give argument mismatch warning like rBef2bde11d228: CMake: Fix spelling for OpenImageDenoise package

Sebastián Barschkis (sebbas) added inline comments.Sep 17 2020, 4:01 PM
build_files/cmake/platform/platform_apple.cmake
420

Aha, so "Potrace" from platform_unix.cmake would also have to change to capital letters?

Ankit Meel (ankitm) added inline comments.Sep 17 2020, 4:04 PM
build_files/cmake/platform/platform_apple.cmake
420

It's not an abbreviation, so not sure why all caps were used.
http://potrace.sourceforge.net/#description
Making a patch to fix FindPotrace.cmake right away. (At least the filename is correct :) )

Sebastián Barschkis (sebbas) added inline comments.Sep 17 2020, 4:18 PM
build_files/cmake/platform/platform_apple.cmake
420

Ok, so with D8923 we should be all set, right?

Ankit Meel (ankitm) added inline comments.Sep 17 2020, 4:18 PM
build_files/cmake/platform/platform_apple.cmake
420

Fixed in {f37c83a12bb2}.
find_package(Potrace) it is. :)

Sebastián Barschkis (sebbas) updated this revision to Diff 28982.Sep 17 2020, 5:00 PM

Fix find_package() function name

Harbormaster completed remote builds in B10268: Diff 28982.Sep 17 2020, 5:00 PM
Ankit Meel (ankitm) awarded a token.Sep 17 2020, 5:05 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 17 2020, 5:31 PM
This revision is now accepted and ready to land.Sep 17 2020, 5:31 PM
Closed by commit rB08a3f01ddcd4: macOS: Added potrace in platform apple cmake (authored by Sebastián Barschkis (sebbas)). · Explain WhySep 17 2020, 5:32 PM
This revision was automatically updated to reflect the committed changes.
Sebastián Barschkis (sebbas) added a commit: rB08a3f01ddcd4: macOS: Added potrace in platform apple cmake.

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
8 lines

Diff 28975

View Options

build_files/cmake/platform/platform_apple.cmake

Loading...