Page MenuHome

Outliner: Move collection exclude icon to restrict column
ClosedPublic

Authored by Nathan Craddock (natecraddock) on Sep 17 2020, 5:28 PM.
Tags
Tokens
"Like" token, awarded by shader."Love" token, awarded by lopoIsaac."Love" token, awarded by gilberto_rodrigues."Like" token, awarded by RedMser.

Details

Summary

Move the collection exclude icon right to be with the other restrict
buttons. This makes the button consitent with the other restrict icons,
and it removes the additional offset caused by drawing the checkbox next
to the collection icon & name, which makes the visual hierarchy more
clear.

This also has the benefit of completely removing some duplicated code used for drawing the checkbox.

Diff Detail

Repository
rB Blender

Event Timeline

Nathan Craddock (natecraddock) requested review of this revision.Sep 17 2020, 5:28 PM
Nathan Craddock (natecraddock) created this revision.

+1

I personally did not like this design when I first saw it because enable/disable affects the collection and its hierarchy in a way that the other restriction columns don't (removes objects from depsgraph, even removes hierarchy lines and restriction columns underneath).

However! Actually seeing this in context with large files, hierarchy is way more clear now with all objects indented under the collection name. This improves readability in large files.

One note: when the collection is disabled (checkbox ticked off), shouldn't the restriction columns be faded? Just like the collection name and icon.

This revision is now accepted and ready to land.Sep 24 2020, 4:29 PM

Personally I also like this change.

We already discussed it with Dalai, and he's fine with it. The only suggestion he had was separating it better visually from the other icons. Maybe we could draw a vertical line? It is a higher level switch so it was intentional to keep it on the left. But with the new patch the hierarchy becomes more clear, which is (arguably) the more important thing to communicate visually.
I still want @Brecht Van Lommel (brecht)'s feedback, so adding him as reviewer.

  • Fade restrict buttons on collection exclude

The only suggestion he had was separating it better visually from the other icons. Maybe we could draw a vertical line? It is a higher level switch so it was intentional to keep it on the left.

I think adding a vertical line would just add visual noise. As far as users are concerned, "exclude" is just another RTO.

Interesting approach

I don't feel strongly about this either way, if the other members of the UI team prefer it then it's fine with me.