Fix T80904: GPencil: bones cannot be transformed when in weightpaint mode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 17 2020, 9:35 PM.

Details

Reviewers

Antonio Vazquez (antoniov)
Germano Cavalcante (mano-wii)

Maniphest Tasks

T80904: GPencil: bones cannot be transformed when in weightpaint mode

Commits

rB7bfcd99a9058: Fix T80904: GPencil: bones cannot be transformed when in weightpaint

Summary

OB_MODE_WEIGHT_GPENCIL was not respected in createTransData.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 17 2020, 9:35 PM

Harbormaster completed remote builds in B10279: Diff 29000.Sep 17 2020, 9:35 PM

Philipp Oeser (lichtwerk) requested review of this revision.Sep 17 2020, 9:35 PM

Philipp Oeser (lichtwerk) added projects: Grease Pencil, Modeling.Sep 17 2020, 10:08 PM

Looks good.
The description of the commit can be a little more explanatory, for example:

The transform convert of type TC_POSE was not being defined if the object mode was OB_MODE_WEIGHT_GPENCIL.

This revision is now accepted and ready to land.Sep 17 2020, 10:12 PM

In D8934#219328, @Germano Cavalcante (mano-wii) wrote:

Looks good.
The description of the commit can be a little more explanatory, for example:

The transform convert of type TC_POSE was not being defined if the object mode was OB_MODE_WEIGHT_GPENCIL.

+1, thx checking!

Closed by commit rB7bfcd99a9058: Fix T80904: GPencil: bones cannot be transformed when in weightpaint (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 18 2020, 10:15 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB7bfcd99a9058: Fix T80904: GPencil: bones cannot be transformed when in weightpaint.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_convert.c

2 lines

Diff 29016

View Options

source/blender/editors/transform/transform_convert.c

Fix T80904: GPencil: bones cannot be transformed when in weightpaint modeClosedPublicActions