Implement ID properties support for TimeMarker
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Sep 18 2020, 5:01 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Inês Almeida (brita_)

Commits

rB216a2218768d: Implement ID properties support for TimeMarker

Summary

Allows scripters to store additional information in the marker itself instead
of using work-around approach based on marker names and such.

Diff Detail

Repository

rB Blender

Branch

time_marker_idprop (branched from master)

Build Status

Buildable 10300
Build 10300: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Sep 18 2020, 5:01 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B10300: Diff 29043.Sep 18 2020, 5:02 PM

Although I didn't see the motivation for this, no issues with the functionality.

Shouldn't copying the marker also copy the properties? (Shift-D in the time-line)
We could display these in the UI (time line region is currently empty :S ), for this we'd want to have an active marker too I'd guess.

This revision is now accepted and ready to land.Sep 18 2020, 5:16 PM

The motivation is to facilitate tools being developed for the movie edit here at the studio.

This is a good point about shift-d. The deletion of markers should also free the properties.

I have a patch for this, but we are experiencing an internet outage at this moment :(

Fix marker duplicate/delete operators.

This revision is now accepted and ready to land.Sep 18 2020, 5:54 PM

Harbormaster completed remote builds in B10302: Diff 29048.Sep 18 2020, 5:54 PM

Inês Almeida (brita_) awarded a token.Sep 19 2020, 11:51 AM

Inês Almeida (brita_) accepted this revision.Sep 19 2020, 12:05 PM

Closed by commit rB216a2218768d: Implement ID properties support for TimeMarker (authored by Sergey Sharybin (sergey)). · Explain WhySep 21 2020, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB216a2218768d: Implement ID properties support for TimeMarker.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

scene.c

28 lines

blenloader/

intern/

readfile.c

9 lines

writefile.c

4 lines

depsgraph/

intern/

builder/

deg_builder_nodes_scene.cc

4 lines

deg_builder_relations_scene.cc

4 lines

makesdna/

DNA_scene_types.h

1 line

makesrna/

intern/

rna_timeline.c

14 lines

Diff 29043

View Options

source/blender/blenkernel/intern/scene.c

View Options

source/blender/blenloader/intern/readfile.c

View Options

source/blender/blenloader/intern/writefile.c

View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc

View Options

source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc

View Options

source/blender/makesdna/DNA_scene_types.h

View Options

source/blender/makesrna/intern/rna_timeline.c

Implement ID properties support for TimeMarkerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29043

source/blender/blenkernel/intern/scene.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/writefile.c

source/blender/depsgraph/intern/builder/deg_builder_nodes_scene.cc

source/blender/depsgraph/intern/builder/deg_builder_relations_scene.cc

source/blender/makesdna/DNA_scene_types.h

source/blender/makesrna/intern/rna_timeline.c

Implement ID properties support for TimeMarker
ClosedPublic
Actions

Revision Contents
Changeset List