Page MenuHome

Cleanup: Rename functions in interface_panel.c
AbandonedPublic

Authored by Hans Goudey (HooglyBoogly) on Sep 18 2020, 7:33 PM.

Details

Summary

Currently there's a mix of a few different naming conventions for functions in
this file. Mostly the issues I see are unclear names, and a lot of use of the
ui_ prefix for static functions. Although this is somewhat of a noisy change,
it's mostly contained in this file, and it would be quite nice to have consistent naming.

Here is a complete list of the changes:

BeforeAfter
compare_panelpanel_compare_sort_order
panel_active_animation_changedpanels_active_animation_changed
get_panel_expand_flagpanel_expand_flag_from_data_recursive
ui_offset_panel_blockpanel_block_buttons_offset
ui_draw_aligned_panelui_panel_draw_aligned
UI_panel_category_draw_allUI_panel_category_tabs_draw
get_panel_real_size_ypanel_real_size_y
get_panel_size_ypanel_size_y
get_panel_real_ofsypanel_real_offset_y
uiAlignPanelSteppanels_align_step
ui_panels_sizeregion_panels_size
ui_do_animatepanel_animate
ui_do_dragpanel_handle_drag
ui_panel_mouse_state_getpanel_mouse_state_get
ui_panel_drag_collapse_handler_removepanel_drag_collapse_handler_remove
ui_panel_drag_collapsepanels_drag_collapse
ui_panel_drag_collapse_handlerpanel_handle_drag_collapse
ui_panel_drag_collapse_handler_addpanels_drag_collapse_handler_add
ui_handle_panel_headerpanel_handle_header
ui_panel_category_active_setpanel_category_active_set
ui_handle_panel_category_cyclingpanels_handle_category_cycling
ui_panel_custom_data_set_recursivepanel_custom_data_set_recursive
ui_handler_panelpanel_handle_modal
ui_handler_remove_panelpanel_handler_modal_remove

Diff Detail

Repository
rB Blender
Branch
panel-rename-functions (branched from master)
Build Status
Buildable 10304
Build 10304: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 18 2020, 7:33 PM
Hans Goudey (HooglyBoogly) retitled this revision from Cleanup: Rename functions in interface_panel.compare_panel to Cleanup: Rename functions in interface_panel.c.
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
  • Merge branch 'master' into panel-rename-functions
Hans Goudey (HooglyBoogly) retitled this revision from Cleanup: Rename functions in interface_panel.c to UI Code Quality: Rename functions in interface_panel.c.Jan 15 2021, 2:37 AM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) retitled this revision from UI Code Quality: Rename functions in interface_panel.c to Cleanup: Rename functions in interface_panel.c.Feb 26 2021, 2:24 AM