Collada DAE Emission Strength
ClosedPublic
Actions

Authored by Kenzie (kenziemac130) on Sep 19 2020, 12:43 PM.

Details

Reviewers

Commits

rB3873a0f4908a: Fix COLLADA failing to export HDR emission strength

Summary

This is the final version of emission strength for Collada DAE (an early version made it into D4971 by accident). The restrictions for materials in this format is extremely limiting, as such exporting HDR emission strength appears to be unsupported. :(

This change adds a clamp to emission strength to avoid any issues.
Unnecessary emission strength node change has also been removed.
Missing comment was also added back to remain consistent with the rest of the file.

Diff Detail

Repository: rB Blender

Event Timeline

Kenzie (kenziemac130) requested review of this revision.Sep 19 2020, 12:43 PM

Kenzie (kenziemac130) created this revision.

Kenzie (kenziemac130) edited the summary of this revision. (Show Details)

Kenzie (kenziemac130) added a reviewer: Brecht Van Lommel (brecht).Sep 19 2020, 12:45 PM

Kenzie (kenziemac130) mentioned this in D4971: added emission strength to the principled BSDF node..

Brecht Van Lommel (brecht) requested changes to this revision.Sep 21 2020, 1:54 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/io/collada/Materials.cpp
326–330	I want to keep this code, so that the exporter does not make implicit assumptions about defaults which may change.
source/blender/io/collada/collada_utils.cpp
1336–1351	I think it should clamp the combined emission strength and color, since there is nothing in Blender preventing the color to have values > 1.