Page MenuHome
Differential D8956

Fix missing Sculpt Overlays updates when using modifiers
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Sep 19 2020, 5:03 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rBf780bfafcfa9: Fix missing Sculpt Overlays updates when using modifiers
Summary

Now that sculpt mask and face sets can also be drawn without using the
PBVH, these operators need these extra updates when the data changes.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D8956_1 (branched from master)
Build Status
Buildable 10482
Build 10482: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Sep 19 2020, 5:03 PM
Harbormaster completed remote builds in B10306: Diff 29077.Sep 19 2020, 5:03 PM
Pablo Dobarro (pablodp606) requested review of this revision.Sep 19 2020, 5:03 PM
Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Sep 19 2020, 5:19 PM
Sergey Sharybin (sergey) requested changes to this revision.Sep 21 2020, 9:16 AM

Please move the tagging into own utility function, where the logic is implemented in a single place and is explained when is to be used and what is the design decision behind this.

In general, when you see a duplicated code think: should it really be duplicated? More often than never it is not to be duplicated.

This revision now requires changes to proceed.Sep 21 2020, 9:16 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 29404.Sep 30 2020, 12:58 AM
  • review update
Harbormaster completed remote builds in B10482: Diff 29404.Sep 30 2020, 12:58 AM
Sergey Sharybin (sergey) requested changes to this revision.Sep 30 2020, 11:53 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/sculpt_paint/sculpt_intern.h
67

flush is the wrong term here. In blender flush means that tags gets flushed from "parents" to the dependencies. This is tag.

Please also add a brief explanation after which modifications this function is to be used.

This revision now requires changes to proceed.Sep 30 2020, 11:53 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 29916.Oct 14 2020, 1:55 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
Harbormaster completed remote builds in B10717: Diff 29916.Oct 14 2020, 1:55 AM
Sergey Sharybin (sergey) accepted this revision.Oct 14 2020, 10:45 AM
This revision is now accepted and ready to land.Oct 14 2020, 10:45 AM
Closed by commit rBf780bfafcfa9: Fix missing Sculpt Overlays updates when using modifiers (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 20 2020, 1:32 AM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBf780bfafcfa9: Fix missing Sculpt Overlays updates when using modifiers.
Pablo Dobarro (pablodp606) mentioned this in T81929: Sculpt: Mask operators missing drawing update on meshes with shapekeys/modifiers.Oct 21 2020, 6:50 PM
Philipp Oeser (lichtwerk) mentioned this in rBd2f52dccd39b: Fix T81929: Sculpt: Mask operators missing drawing update on meshes with.Oct 21 2020, 8:42 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
5 lines
15 lines
39 lines
1 line

Diff 29404

View Options

source/blender/editors/sculpt_paint/paint_mask.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_face_set.c

Loading...
View Options

source/blender/editors/sculpt_paint/sculpt_intern.h

Loading...