Fix T80996: Weight Proximity modifier: crash going to editmode on a target in certain situations
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 21 2020, 6:05 PM.

Details

Reviewers

Bastien Montagne (mont29)
Campbell Barton (campbellbarton)

Maniphest Tasks

T80996: Weight Proximity modifier: crash going to editmode on a target in certain situations

Commits

rBd037ac315b4d: Fix T80996: Weight Proximity modifier: crash going to editmode on a

Summary

Regression from rBdeaff945d0b96.

mesh_ensure_looptri_data would overflow

Crash would only happen if a second Data Transfer modifier (transferring
UVs) follows, so exact reason for this is not yet entirely clear to me
tbh. Also unclear if this has an unneccessary performance impact?
So basically, I am dropping this here, because "it works" :)

Similar fix as

Diff Detail

Repository

rB Blender

Branch

T80996 (branched from master)

Build Status

Buildable 10337
Build 10337: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Sep 21 2020, 6:05 PM

Harbormaster completed remote builds in B10337: Diff 29142.Sep 21 2020, 6:05 PM

Philipp Oeser (lichtwerk) requested review of this revision.Sep 21 2020, 6:06 PM

Philipp Oeser (lichtwerk) added projects: Modeling, Modifiers.Sep 21 2020, 6:06 PM

Philipp Oeser (lichtwerk) mentioned this in T80996: Weight Proximity modifier: crash going to editmode on a target in certain situations.Sep 21 2020, 6:16 PM

Campbell Barton (campbellbarton) accepted this revision.Sep 22 2020, 6:39 AM

Campbell Barton (campbellbarton) added inline comments.

source/blender/modifiers/intern/MOD_weightvgproximity.c
557	Since this is an expensive operation, I have been adding comments above each use, either justifying why the conversion is acceptable, or noting it as a TODO to avoid the conversion. In this case there are edit-mode versions of the BVH lookup functions so it could be avoided, although it's a fairly obscure case so it's not high priority either. That can noted above this function call, otherwise LGTM.

This revision is now accepted and ready to land.Sep 22 2020, 6:39 AM

Bastien Montagne (mont29) accepted this revision.Sep 22 2020, 8:34 AM

Closed by commit rBd037ac315b4d: Fix T80996: Weight Proximity modifier: crash going to editmode on a (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 22 2020, 9:49 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBd037ac315b4d: Fix T80996: Weight Proximity modifier: crash going to editmode on a.