Page MenuHome
Differential D9010

EEVEE: ShaderToRGB alpha inversed
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Sep 25 2020, 2:17 PM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rB7320ecee9bef: EEVEE: ShaderToRGB alpha inversed
Summary

The alpha out socket output the average transmittance, not the alpha.
This patch will convert the transmittance to alpha.

Found during research of T80919; Issue introduced when Closure.opacity was migrated to Closure.transmittance.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Sep 25 2020, 2:17 PM
Jeroen Bakker (jbakker) created this revision.
Harbormaster completed remote builds in B10402: Diff 29259.Sep 25 2020, 2:17 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 25 2020, 2:19 PM
Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, BF Blender (2.91).
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 25 2020, 2:21 PM
Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Clément Foucault (fclem).
Jeroen Bakker (jbakker) updated this revision to Diff 29260.Sep 25 2020, 2:58 PM

Replaced clamp with saturate

Harbormaster completed remote builds in B10403: Diff 29260.Sep 25 2020, 2:58 PM
Clément Foucault (fclem) accepted this revision.Oct 20 2020, 2:50 PM
This revision is now accepted and ready to land.Oct 20 2020, 2:50 PM
Closed by commit rB7320ecee9bef: EEVEE: ShaderToRGB alpha inversed (authored by Jeroen Bakker (jbakker)). · Explain WhyOct 20 2020, 3:18 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB7320ecee9bef: EEVEE: ShaderToRGB alpha inversed.

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
shaders/
material/
2 lines

Diff 30173

View Options

source/blender/gpu/shaders/material/gpu_shader_material_shader_to_rgba.glsl

Loading...