Page MenuHome

Fix T79275: Missing update for Pinned Active Tool panels displaying in another sidebar
ClosedPublic

Authored by David Friedli (hlorus) on Sep 25 2020, 6:29 PM.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 10414
Build 10414: arc lint + arc unit

Event Timeline

David Friedli (hlorus) requested review of this revision.Sep 25 2020, 6:29 PM
David Friedli (hlorus) created this revision.
Hans Goudey (HooglyBoogly) requested changes to this revision.Sep 25 2020, 7:08 PM

Thanks for the patch! Close, just one comment.

source/blender/editors/screen/area.c
463

This should have a check for whether the panel is active. Looping through all of the region's panels contains everything, even panels that aren't visible.

Because that's stored in the panel_runtime flag which has defines in interface_panel.c, you'll need to create a helper function there:

bool UI_panel_is_active(Panel *panel)
{
  return panel->runtime_flag & PANEL_ACTIVE;
}
This revision now requires changes to proceed.Sep 25 2020, 7:08 PM
  • Only check visible panels
  • Rebase

Wow that was a fast response :)
I've added that check now. Would be great if you could commit for me, also feel free do make adjustments if needed.

David Friedli (hlorus) marked an inline comment as done.Sep 26 2020, 9:27 AM
This revision is now accepted and ready to land.Sep 28 2020, 6:30 AM