T80395 In cycles, ignore disabled surfaces when baking.
ClosedPublic
Actions

Authored by Martijn Versteegh (Baardaap) on Sep 25 2020, 8:55 PM.

Details

Reviewers

Dalai Felinto (dfelinto)
Brecht Van Lommel (brecht)
Aaron Carlisle (Blendify)

Commits

rC8e029e1c801a: Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer
rBf117966c4e27: Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer

Summary

When disabling surfaces in Cycles' Filter panel and then baking a texture Blender crashes.

The baking data references the surface triangles,so not syncing surfaces
leads to a crash. Surfaces are the only objects that support baking
so having surfaces disabled makes no sense and is probably not what the
user meant to do. So when baking, just ignore this filter setting and sync
surfaces anyway.

Diff Detail

Repository

rB Blender

Branch

fixT80395 (branched from master)

Build Status

Buildable 10410
Build 10410: arc lint + arc unit

Event Timeline

Martijn Versteegh (Baardaap) requested review of this revision.Sep 25 2020, 8:55 PM

Martijn Versteegh (Baardaap) created this revision.

Harbormaster completed remote builds in B10409: Diff 29275.Sep 25 2020, 8:55 PM

This makes cycles ignore disabled surfaces in the view layer when baking.

Harbormaster completed remote builds in B10410: Diff 29276.Sep 25 2020, 8:56 PM

Martijn Versteegh (Baardaap) mentioned this in D9005: Before starting a texture bake, check surfaces are enabled in the viewlayer. (T80395).Sep 25 2020, 9:01 PM

Martijn Versteegh (Baardaap) added reviewers: Dalai Felinto (dfelinto), Brecht Van Lommel (brecht).

Martijn Versteegh (Baardaap) edited the summary of this revision. (Show Details)Sep 30 2020, 8:24 PM

Since Aaron Carlisle was the first to look at the original patch I added him here as well.

Is there someone else I should ask to look at this? Should I keep pinging people, or is everybody just very busy and will get to it eventually?

Dalai Felinto's remarks convinced me this is the right approach, and it's a really simple solution as well. It would be a shame if this small fix would fall through the cracks. It isn't really an important thing, but crashes are always annoying.

Dalai Felinto (dfelinto) added a project: Render & Cycles.Sep 30 2020, 10:23 PM

Brecht Van Lommel (brecht) accepted this revision.Oct 1 2020, 2:31 PM

This revision is now accepted and ready to land.Oct 1 2020, 2:31 PM

Closed by commit rBf117966c4e27: Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer (authored by Martijn Versteegh (Baardaap), committed by Brecht Van Lommel (brecht)). · Explain WhyOct 1 2020, 2:43 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBf117966c4e27: Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer.

Stefan Werner (swerner) added a commit: rC8e029e1c801a: Fix T80395: Cycles baking crash when Surfaces are disabled in the view layer.Mar 1 2021, 2:18 AM