Page MenuHome
Differential D9022

Volumes: Support selection and outlines in viewport.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Sep 27 2020, 12:13 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Commits
rBe12767a0352a: Volumes: support selection and outlines in viewport
Summary

Previously, one could only select a volume object in the outliner or by clicking on the object origin. This patch allows you to click on the actual volume.
Furthermore, the generated (invisible) mesh that is used for selection is also used to draw an outline for the volume object now.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Sep 27 2020, 12:13 AM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B10422: Diff 29294.Sep 27 2020, 12:13 AM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Sep 27 2020, 12:16 AM
Jacques Lucke (JacquesLucke) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).Sep 27 2020, 12:18 AM
Brecht Van Lommel (brecht) awarded a token.Sep 28 2020, 10:43 AM
Brecht Van Lommel (brecht) added a comment.Sep 28 2020, 12:29 PM

This looks great, just minor comments.

source/blender/blenkernel/intern/volume_render.cc
193

Keep comments.

210–211

This code got removed, but as far as I can tell it's still needed? getCenter() and getCornerPoints() don't seem to do the required + 1.

Also, include should be inclusive.

231

Keep this comment.

Brecht Van Lommel (brecht) requested changes to this revision.Sep 28 2020, 12:29 PM
This revision now requires changes to proceed.Sep 28 2020, 12:29 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 29325.Sep 28 2020, 1:46 PM
  • bring back comments and inclusive bounding boxes
Harbormaster completed remote builds in B10434: Diff 29325.Sep 28 2020, 1:46 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 28 2020, 5:20 PM
This revision is now accepted and ready to land.Sep 28 2020, 5:20 PM
Closed by commit rBe12767a0352a: Volumes: support selection and outlines in viewport (authored by Jacques Lucke (JacquesLucke)). · Explain WhySep 29 2020, 12:40 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBe12767a0352a: Volumes: support selection and outlines in viewport.
Philipp Oeser (lichtwerk) mentioned this in T81292: Hair: Support selection (and outlines or alternative vizualisation) in viewport.Sep 29 2020, 1:44 PM
Lucas Schlindwein (Xlindvain) awarded a token.Oct 5 2020, 12:40 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
10 lines
intern/
452 lines
draw/
1 line
engines/
overlay/
6 lines
16 lines
6 lines
67 lines
intern/
1 line
6 lines
1 line
47 lines

Diff 29364

View Options

source/blender/blenkernel/BKE_volume_render.h

Loading...
View Options

source/blender/blenkernel/intern/volume_render.cc

Loading...
View Options

source/blender/draw/CMakeLists.txt

Loading...
View Options

source/blender/draw/engines/overlay/overlay_engine.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_outline.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_private.h

Loading...
View Options

source/blender/draw/engines/overlay/overlay_volume.c

Loading...
View Options

source/blender/draw/intern/draw_cache.h

Loading...
View Options

source/blender/draw/intern/draw_cache.c

Loading...
View Options

source/blender/draw/intern/draw_cache_impl.h

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_volume.c

Loading...