Page MenuHome
Differential D9025

UI: Fix for checkbox width calculation
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Sep 27 2020, 1:38 PM.

Details

Reviewers
Julian Eisel (Severin)
Aaron Carlisle (Blendify)
Hans Goudey (HooglyBoogly)
Commits
rB5af8fc8192c4: UI: Improved Checkbox Width Calculation
Summary

UI: Fix for checkbox width calculation.

The button rect depends on "Line Width", this should be taken into account
when calculating the width of the checkbox. Although this is not particularly evident
due to int rounding, but it is here.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Sep 27 2020, 1:38 PM
Yevgeny Makarov (jenkm) created this revision.
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Sep 27 2020, 1:44 PM
Aaron Carlisle (Blendify) added inline comments.
source/blender/editors/interface/interface_widgets.c
4060

This comment should be updated because the factor is being removed.

Yevgeny Makarov (jenkm) added a comment.Sep 27 2020, 1:54 PM
This comment was removed by Yevgeny Makarov (jenkm).
Yevgeny Makarov (jenkm) updated this revision to Diff 29316.Sep 28 2020, 10:54 AM
Yevgeny Makarov (jenkm) marked an inline comment as done.
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) removed a subscriber: Aaron Carlisle (Blendify).

Remove the changes to the text offset from this patch.

Aaron Carlisle (Blendify) accepted this revision.Sep 30 2020, 1:51 PM
This revision is now accepted and ready to land.Sep 30 2020, 1:51 PM
Yevgeny Makarov (jenkm) added a reviewer: Hans Goudey (HooglyBoogly).Oct 27 2020, 8:35 PM
Yevgeny Makarov (jenkm) added a subscriber: Harley Acheson (harley).
Hans Goudey (HooglyBoogly) accepted this revision.Oct 28 2020, 5:24 PM

I'm not that familiar with this code, but based on the description this seems like a reasonable change. It's still a bit unfortunate to have the numbers without any description here, like "6", but that's not necessarily in the scope of this patch.

Julian Eisel (Severin) accepted this revision.Oct 28 2020, 5:38 PM
Closed by commit rB5af8fc8192c4: UI: Improved Checkbox Width Calculation (authored by Yevgeny Makarov (jenkm), committed by Harley Acheson (harley)). · Explain WhyOct 28 2020, 6:22 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rB5af8fc8192c4: UI: Improved Checkbox Width Calculation.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
4 lines

Diff 29300

View Options

source/blender/editors/interface/interface_widgets.c

Loading...