Details

Reviewers

Group Reviewers

Commits

rB53792e32e7dc: UI: Show more information in open file tooltip

Summary

Hi, I made this little patch to add filepath as tooltip description dynamically for menu items in File > Open Recent...
it should not break when not having a filepath as param, in that case will show the original tooltip description.

This idea is taken from a RSC proposal, see:
https://blender.community/c/rightclickselect/B2gbbc/

Video:

Diff Detail

Event Timeline

Juanfran Matheu (jfmatheu) requested review of this revision.Sep 27 2020, 5:42 PM

Juanfran Matheu (jfmatheu) created this revision.

Juanfran Matheu (jfmatheu) edited the summary of this revision. (Show Details)Sep 27 2020, 5:46 PM

What's wrong with the python tooltips? IIRC it shows the filepath.

Might be best to just ADD your "get_description" and leave the existing "description" there. Then inside your "get_description" just return NULL if there isn't a filepath. That way it would just return the existing "Open a Blender File" in that case.

Note that you can test for that "filepath" without reading it, like...

if (RNA_struct_property_is_set(params, "filepath")) {
  char path[FILE_MAX];
  RNA_string_get(params, "filepath", path);
  return BLI_strdup(path);
}
return NULL;

Just in case you appreciate the inspiration, you can get something like the following:

with this:

static char *wm_open_mainfile_description(struct bContext *UNUSED(C),
                                          struct wmOperatorType *UNUSED(op),
                                          struct PointerRNA *params)
{
  if (RNA_struct_property_is_set(params, "filepath")) {
    char path[FILE_MAX];
    RNA_string_get(params, "filepath", path);

    BLI_stat_t stats;
    if (BLI_stat(path, &stats) == -1) {
      return BLI_sprintfN("%s\n\n[%s]", path, N_("File Not Found"));
    }

    char date_st[16];
    char time_st[8];
    bool is_today, is_yesterday;
    BLI_filelist_entry_datetime_to_string(
        NULL, (int64_t)stats.st_mtime, false, time_st, date_st, &is_today, &is_yesterday);
    if (is_today || is_yesterday) {
      BLI_strncpy(date_st, is_today ? N_("Today") : N_("Yesterday"), sizeof(date_st));
    }

    char size_str[16];
    BLI_filelist_entry_size_to_string(NULL, (uint64_t)stats.st_size, false, size_str);
    char bytes_str[64];
    BLI_str_format_uint64_grouped(bytes_str, (uint64_t)stats.st_size);

    return BLI_sprintfN("%s\n\n%s: %s %s\n%s: %s (%s %s)",
                        path,
                        N_("Modified"),
                        date_st,
                        time_st,
                        N_("Size"),
                        size_str,
                        bytes_str,
                        N_("bytes"));
  }
  return NULL;
}