Page MenuHome
Differential D9030

UI: Popover arrows are clipped
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Sep 28 2020, 12:37 AM.

Details

Reviewers
Julian Eisel (Severin)
Group Reviewers
User Interface
Commits
rB1ebb7afe1d8d: UI: Popover Position Change
Summary

UI: Popover arrows are clipped.

This came out after changes in T65351, rBfe3ce615287a.

The clipping can be corrected this way:
https://developer.blender.org/D9030?id=29434
but I'm not sure if there are any side effects.

So I just slightly increased the value of UI_POPUP_MENU_TOP,
but perhaps there is a smarter solution that only affects this arrows.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Sep 28 2020, 12:37 AM
Yevgeny Makarov (jenkm) created this revision.
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Sep 29 2020, 2:23 PM

Hi, can you please use arc diff? This way we can see the context code around it.

Yevgeny Makarov (jenkm) updated this revision to Diff 29434.Sep 30 2020, 11:45 PM
Dalai Felinto (dfelinto) added a comment.Oct 1 2020, 10:27 AM

I haven't tried the patch, but I'm surprised this is not margin + UI_POPUP_MENU_TOP.

Yevgeny Makarov (jenkm) updated this revision to Diff 29463.Oct 1 2020, 11:58 AM

Changed the value of UI_POPUP_MENU_TOP.
Probably this is more correct (although the previous one also worked for me).

Perhaps there is another solution that affects only the popover arrows.

Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)Oct 9 2020, 8:56 AM
Yevgeny Makarov (jenkm) added a reviewer: User Interface.
Julian Eisel (Severin) accepted this revision.Oct 20 2020, 6:31 PM
This revision is now accepted and ready to land.Oct 20 2020, 6:31 PM
Harley Acheson (harley) awarded a token.Oct 20 2020, 7:13 PM
Closed by commit rB1ebb7afe1d8d: UI: Popover Position Change (authored by Yevgeny Makarov (jenkm), committed by Harley Acheson (harley)). · Explain WhyOct 28 2020, 4:54 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rB1ebb7afe1d8d: UI: Popover Position Change.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
2 lines

Diff 29310

View Options

source/blender/editors/interface/interface_region_popup.c

Loading...