This new "Mesh to Volume" modifier can only be added to Volume objects. It takes a mesh as input and generates a "density" near the surface or in the enclosed volume.
Ref T73201.
Details
Details
- Reviewers
Brecht Van Lommel (brecht) - Maniphest Tasks
- T73201: New volume object type
- Commits
- rB5845c06a63a6: Volumes: new Mesh to Volume modifier
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- mesh-to-volume-modifier (branched from master)
- Build Status
Buildable 10448 Build 10448: arc lint + arc unit
Event Timeline
| source/blender/makesrna/intern/rna_modifier.c | ||
|---|---|---|
| 7035–7043 | This is "band width" rather than "bandwidth". I see some other apps name it like that, but I think they made a mistake and didn't notice that it's exteriorBandWidth rather than exteriorBandwidth. Perhaps best would be to more consistent with Blender terminology and parameters for the solidify modifier, where there is "thickness" and "offset". Offset would only available when fill volume is disabled. 0 would be only interior band, 0.5 in the middle and 1.0 only exterior. | |
| source/blender/modifiers/intern/MOD_mesh_to_volume.cc | ||
| 222 | This can use BKE_modifier_get_evaluated_mesh_from_evaluated_object, and then it should work for other objects types that output meshes (like curves and metaballs). | |
| 244 | false -> true to clear the grid contents? And then merging should be very cheap. Otherwise the density grid may already exist, and I think we should replace it. The transform should also be reset. | |
| 252–253 | Can this be added to the transform in OpenVDBMeshAdapter, or is it required after conversion? It's not a big deal, just would be a bit more elegant without an additional translation in the output. | |
| 255 | The density should be a setting on the modifier. | |
| source/blender/makesrna/intern/rna_modifier.c | ||
|---|---|---|
| 7035–7043 | Changing to "band width" sounds good. I think using "thickness" and "offset" could be quite confusing when the mesh does not enclose a mesh. In that case only the exterior band width has an effect. OpenVDB does not check the normals to decide what is inside/outside. | |
| source/blender/modifiers/intern/MOD_mesh_to_volume.cc | ||
| 244 | Right now I'm creating a new volume object anyway, so the density grid never exists. I can change that and replace the density grid on the incoming volume. | |
| source/blender/makesrna/intern/rna_modifier.c | ||
|---|---|---|
| 7035–7043 | Ok, that seems reasonable. | |
| source/blender/modifiers/intern/MOD_mesh_to_volume.cc | ||
| 244 | Ah of course, I didn't even notice that. Creating an entire new volume and discarding other grids seems correct as is. An option to combine with another grid would be useful, but probably that is best left to nodes and a merge volume node. | |
Comment Actions
- support other object types
- "bandwidth" to "band width"
- expose density parameter
- improve comment
- move better voxel alignment matrix
Comment Actions
Here are some small comments on the tooltips. It's just nice to have newly added tooltips align with the guidelines being developed (T76261)
| source/blender/makesrna/intern/rna_modifier.c | ||
|---|---|---|
| 6991 | I don't think "Specify the" is necessary here, or in the description for "Voxel Size" | |
| 7020 | This one is more subtle, but this might be phrased more succintly with "Smaller values result in a higher resolution output" | |
| 7025 | Similarly, "The desired" is just extra words here. | |
Comment Actions
- improve tooltips
- fix voxel size computation when object is rotated
- correct the grid-mesh-alignment
Comment Actions
I think this is ok during bcon2. It's a fairly isolated feature that shouldn't break anything and improves on an existing project (the volume object).