Paths

Table of Contentst

Differential D9036

Fix T80121: Forcefield F-curve modifier changes don't reset cache
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Sep 28 2020, 3:30 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T80121: Forcefield F-curve modifier changes don't reset frames in memory

Summary

Add a dependency graph relation Force Object Animation → Scene Rigid Body World Rebuild. This ensures that the rigid body world is rebuilt when a force object is re-tagged for animation updates.

The extra relation doesn't add any new calculations when the animation is running, as the Time Source node already had a relation to the scene's RIGIDBODY_REBUILD node.

The relation is created directly to the RIGIDBODY_REBUILD Operation. I would have liked to target the containing Component instead. However, that has the RIGIDBODY_SIM operation as entry node, which isn't enough to actually fix T80121.

Diff Detail

Repository

rB Blender

Branch

temp-T80121-force-fcurve-updates (branched from master)

Build Status

Buildable 10440
Build 10440: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) created this revision.Sep 28 2020, 3:30 PM

Harbormaster completed remote builds in B10440: Diff 29336.Sep 28 2020, 3:30 PM

Sybren A. Stüvel (sybren) requested review of this revision.Sep 28 2020, 3:30 PM

I think the fact that RIGIDBODY_SIM is the entry operation is actually a typo.

As discussed here, we might go into more granular checks before adding the relation, but it also have downsides (slower build, etc). For now I think this is a fine solution.

This revision is now accepted and ready to land.Sep 28 2020, 3:45 PM

Philipp Oeser (lichtwerk) mentioned this in D9031: FModifers RNA update: call corresponding FCurve properties RNA update as well.Sep 28 2020, 4:37 PM

RedMser (RedMser) awarded a token.Oct 1 2020, 8:10 PM

Already committed on: 48a0c931eea84fb072ce0b958090dda4b27cabff

I would have liked to target the containing Component instead. However, that has the RIGIDBODY_SIM operation as entry node, which isn't enough to actually fix T80121.

Adding any keyframe to a force object (can be "regular" transform keys) will spit out following warning:

add_relation(Animation -> Rigid Body) - Failed, but op_from (ComponentKey(OBForce, ANIMATION)) was ok
add_relation(Animation -> Rigid Body) - Could not find op_to (OperationKey(type: TRANSFORM, component name: '', operation code: RIGIDBODY_REBUILD))

Harmless?

Revision Contents
Changeset List

Path

Size

source/

blender/

depsgraph/

intern/

builder/

deg_builder_relations.h

1 line

deg_builder_relations.cc

19 lines

Diff 29336

View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.h