Page MenuHome
Differential D9038

Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Sep 28 2020, 4:42 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T81254: EEVEE: Scattering pass is also outputted as Transmittance Volume Renderpass
Commits
rB6b1042f45a58: Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics
rB7c373555fd5d: Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics
Summary

Regular rendering uses a custom blend mode, but render passes renders to
2 separate textures. This wasn't configured correctly inside the
fragment shaders. This patch adds a switch to configure the fragment
shader with the correct attachments.

Backport to Blender 2.83.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Sep 28 2020, 4:42 PM
Jeroen Bakker (jbakker) created this revision.
Harbormaster completed remote builds in B10443: Diff 29340.Sep 28 2020, 4:42 PM
Jeroen Bakker (jbakker) updated this revision to Diff 29343.Sep 28 2020, 4:56 PM

Created 2 versions of the shader

Harbormaster completed remote builds in B10446: Diff 29343.Sep 28 2020, 4:56 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Sep 28 2020, 4:57 PM
Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, BF Blender (2.91).
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
Jeroen Bakker (jbakker) updated this revision to Diff 29357.Sep 29 2020, 10:30 AM

Rebased with latest master

Harbormaster completed remote builds in B10454: Diff 29357.Sep 29 2020, 10:30 AM
Jeroen Bakker (jbakker) added a child revision: D9048: Eevee: Add Volume Transmittance to Color Render Passes..Sep 29 2020, 1:52 PM
Jeroen Bakker (jbakker) removed a child revision: D9048: Eevee: Add Volume Transmittance to Color Render Passes..
Jeroen Bakker (jbakker) added a parent revision: D9048: Eevee: Add Volume Transmittance to Color Render Passes..
Jeroen Bakker (jbakker) removed a parent revision: D9048: Eevee: Add Volume Transmittance to Color Render Passes..
Jeroen Bakker (jbakker) added a child revision: D9048: Eevee: Add Volume Transmittance to Color Render Passes..Sep 29 2020, 1:55 PM
Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Clément Foucault (fclem).Oct 6 2020, 12:30 PM
Clément Foucault (fclem) accepted this revision.Oct 7 2020, 3:08 PM
This revision is now accepted and ready to land.Oct 7 2020, 3:08 PM
Closed by commit rB7c373555fd5d: Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics (authored by Jeroen Bakker (jbakker)). · Explain WhyOct 7 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB7c373555fd5d: Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics.
Jeroen Bakker (jbakker) added a commit: rB6b1042f45a58: Fix T81254: Incorrect calculation of EEVEE Transmittance Volumetrics.Oct 28 2020, 9:59 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
2 lines
18 lines
4 lines
shaders/
4 lines
5 lines
tests/
3 lines

Diff 29701

View Options

source/blender/draw/engines/eevee/eevee_private.h

Loading...
View Options

source/blender/draw/engines/eevee/eevee_shaders.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_volumes.c

Loading...
View Options

source/blender/draw/engines/eevee/shaders/volumetric_accum_frag.glsl

Loading...
View Options

source/blender/draw/engines/eevee/shaders/volumetric_resolve_frag.glsl

Loading...
View Options

source/blender/draw/tests/shaders_test.cc

Loading...