Ankit Meel (ankitm) retitled this revision from Fix T81100: ASan SEGV due to bad pointer dereference. to Fix T81100: ccl::Node: ASan SEGV due to bad pointer.Sep 28 2020, 8:41 PM

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Ankit Meel (ankitm) added a task: T81100: Crash on launch: AddressSanitizer: SEGV on unknown address.

@Campbell Barton (campbellbarton) I don't have a gcc compiler. Since you added the CHECK_TYPE macro, could you check if this change works on gcc ?

@Ankit Meel (ankitm) no issues building this here.

This revision is now accepted and ready to land.Sep 29 2020, 10:28 AM

Ankit Meel (ankitm) added a reviewer: Brecht Van Lommel (brecht).Sep 29 2020, 10:30 AM

This was required at some point since offsetof didn't work with all C++ classes, now that we have C++17 it should work with all the compilers we support as far as I can tell.

Closed by commit rBc1cdde04e270: Fix T81100: ccl::Node: ASan SEGV due to bad pointer (authored by Ankit Meel (ankitm)). · Explain WhySep 29 2020, 9:47 PM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rBc1cdde04e270: Fix T81100: ccl::Node: ASan SEGV due to bad pointer.

Stefan Werner (swerner) added a commit: rC473e28d134fd: Fix T81100: ccl::Node: ASan SEGV due to bad pointer.Mar 1 2021, 2:18 AM