Paths

Table of Contentst

Differential D9046

Fix T81248: World nodetree action is linked after duplication
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 29 2020, 10:53 AM.

Tags

Subscribers

None

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T81248: can't delete animation of duplicated environment (world)

Commits

rBf79b4850fb3c: Fix T81248: World nodetree action is linked after duplication

Summary

This was already changed for Material nodetrees on duplication in
rBa75ac18638f4.
Since it is not obvious from the UI how change World actions - and to be
consistent with Material actions, it is best to copy the action as the
default behavior.
So use generic BKE_id_copy functions with LIB_ID_COPY_ACTIONS flag [which
also enables us to get rid of BKE_world_copy]

I would also propose to take the User Preference USER_DUP_ACT into
account (for both material and world actions) as a followup step?

Diff Detail

Repository

Branch

T81248 (branched from master)

Build Status

Buildable 10455
Build 10455: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 29 2020, 10:53 AM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B10455: Diff 29358.Sep 29 2020, 10:54 AM

Philipp Oeser (lichtwerk) added a project: Pipeline, Assets & I/O.Sep 29 2020, 11:11 AM

LGTM, indeed taking userpreferences into account here would make sense too.

This revision is now accepted and ready to land.Sep 30 2020, 1:38 PM

Philipp Oeser (lichtwerk) mentioned this in T81248: can't delete animation of duplicated environment (world) .Sep 30 2020, 3:21 PM

Will hold this back until we have clarity over T81267: Assert adding a new material with animation through the material template_ID

taking userpreferences into account here would make sense too

I guess it would even make sense for id_single_user? (also taking the User Preference into account)

Closed by commit rBf79b4850fb3c: Fix T81248: World nodetree action is linked after duplication (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 1 2020, 3:53 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBf79b4850fb3c: Fix T81248: World nodetree action is linked after duplication.

Philipp Oeser (lichtwerk) mentioned this in D9150: Duplication in template_ID: take User Preference for duplicating actions into account.Oct 8 2020, 12:54 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

1 line

intern/

7 lines

editors/

render/

render_shading.c

4 lines

Diff 29358

source/blender/blenkernel/BKE_world.h

Loading...

source/blender/blenkernel/intern/world.c

Loading...

source/blender/editors/render/render_shading.c

Loading...