Page MenuHome
Differential D9051

Don't initialize Wintab if Tablet API is set to Native.
ClosedPublic
Actions

Authored by Nicholas Rishel (nicholas_rishel) on Sep 29 2020, 10:18 PM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Brecht Van Lommel (brecht)
Commits
rBf18725662474: Windows: workaround to make Windows Ink tablet API work
Summary

Intializing and enabling Wintab disables Windows Ink, this serves as a stopgap to allow use of Windows Ink until runtime API switching is merged.

Diff Detail

Repository
rB Blender

Event Timeline

Nicholas Rishel (nicholas_rishel) requested review of this revision.Sep 29 2020, 10:18 PM
Nicholas Rishel (nicholas_rishel) created this revision.
Harbormaster completed remote builds in B10475: Diff 29394.Sep 29 2020, 10:18 PM
Ray Molenkamp (LazyDodo) accepted this revision.Sep 29 2020, 10:33 PM
Ray Molenkamp (LazyDodo) added a reviewer: Brecht Van Lommel (brecht).
Ray Molenkamp (LazyDodo) added subscribers: Brecht Van Lommel (brecht), Ray Molenkamp (LazyDodo).

I can't test currently, but the change seems ok as a stop gap measure before we can land D7840 (target is 2.92 there) and get the sculpting guys going.

@Brecht Van Lommel (brecht) any objections?

This revision is now accepted and ready to land.Sep 29 2020, 10:33 PM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): Brecht Van Lommel (brecht).Sep 30 2020, 11:52 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Setting Brecht as blocking since Ray still wants to hear from him. This way the patch doesn't look as "accepted" on its status.

This revision now requires review to proceed.Sep 30 2020, 11:52 AM
Dalai Felinto (dfelinto) added a project: Sculpt, Paint & Texture.Sep 30 2020, 11:53 AM
Brecht Van Lommel (brecht) added a comment.Sep 30 2020, 4:40 PM

I'm fine with this, but can the tooltip also be extended to indicate that changing the settings requires a Blender restart to take effect?

Nicholas Rishel (nicholas_rishel) updated this revision to Diff 29452.Oct 1 2020, 4:46 AM
  • Add tooltip notification that changing tablet API requires restarting Blender.
Harbormaster completed remote builds in B10506: Diff 29452.Oct 1 2020, 4:46 AM
Nicholas Rishel (nicholas_rishel) added a comment.Oct 1 2020, 4:49 AM

@Brecht Van Lommel (brecht) updated as requested.

Brecht Van Lommel (brecht) accepted this revision.Oct 1 2020, 12:02 PM
This revision is now accepted and ready to land.Oct 1 2020, 12:02 PM
Closed by commit rBf18725662474: Windows: workaround to make Windows Ink tablet API work (authored by Nicholas Rishel (nicholas_rishel), committed by Brecht Van Lommel (brecht)). · Explain WhyOct 1 2020, 12:20 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBf18725662474: Windows: workaround to make Windows Ink tablet API work.

Revision Contents
Changeset List

PathSize
intern/
ghost/
intern/
2 lines
source/
blender/
makesrna/
intern/
6 lines

Diff 29467

View Options

intern/ghost/intern/GHOST_WindowWin32.cpp

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...