Page MenuHome
Differential D9063

Fix T81340: UBSan: addition of unsigned offset causes overflow
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Oct 1 2020, 1:14 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T81340: UBSan: several runtime errors at launch.
Commits
rB63c906e0a7e5: Fix T81340: UBSan: addition of unsigned offset causes overflow
Summary

The warning:
runtime error: addition of unsigned offset to 0x61a0000b22d8
overflowed to 0x61a0000b22b8

Fix T81340 (partially)

Diff Detail

Repository
rB Blender

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Oct 1 2020, 1:14 AM
Ankit Meel (ankitm) created this revision.
Harbormaster completed remote builds in B10497: Diff 29437.Oct 1 2020, 1:14 AM
Ankit Meel (ankitm) mentioned this in T81340: UBSan: several runtime errors at launch. .Oct 1 2020, 1:24 AM
Campbell Barton (campbellbarton) accepted this revision.Oct 1 2020, 5:43 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) added inline comments.
source/blender/blenloader/intern/readfile.c
287

Casting to int is fine in this case. As it's just a signed offset of a few bytes, otherwise LGTM.

This revision is now accepted and ready to land.Oct 1 2020, 5:43 AM
Campbell Barton (campbellbarton) retitled this revision from Fix T81340: UBSan: addition of unsigned offset causes oveflow to Fix T81340: UBSan: addition of unsigned offset causes overflow.Oct 1 2020, 5:44 AM
Ankit Meel (ankitm) updated this revision to Diff 29453.Oct 1 2020, 8:26 AM
Ankit Meel (ankitm) marked an inline comment as done.
  • Cast to int, not int64_t
Harbormaster completed remote builds in B10507: Diff 29453.Oct 1 2020, 8:26 AM
Closed by commit rB63c906e0a7e5: Fix T81340: UBSan: addition of unsigned offset causes overflow (authored by Ankit Meel (ankitm)). · Explain WhyOct 1 2020, 10:57 AM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rB63c906e0a7e5: Fix T81340: UBSan: addition of unsigned offset causes overflow.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
2 lines

Diff 29458

View Options

source/blender/blenloader/intern/readfile.c

Loading...