Sculpt: Union and Join mode for trim tools
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 1 2020, 1:20 AM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rB2b72860ff447: Sculpt: Union and Join mode for trim tools

Summary

This enables a union boolean mode for the trimming gestures tools which
adds geometry to the mesh instead of cutting it.
It also adds a Join mode, which adds the geometry directly without
using a boolean operation.
Depending if you plan to use dyntopo or not, it is useful to have both
options available.

This is using the full depth of the object from the camera view for the
depth of the geometry, but options for controlling the trimming depth in
all modes are going to be added in later patches

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 1 2020, 1:20 AM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B10500: Diff 29440.Oct 1 2020, 1:20 AM

Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Enable Union mode for the trim tool to Sculpt: Enable Union mode for the trim tools.Oct 1 2020, 1:24 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)

Pablo Dobarro (pablodp606) added a subscriber: Daniel Bystedt (dbystedt).

Roberto Roch Diago (sick) added a subscriber: Roberto Roch Diago (sick).Oct 1 2020, 2:39 AM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 1 2020, 8:27 AM

Lopo Isaac (lopoIsaac) awarded a token.Oct 1 2020, 11:26 AM

Metin Seven (MetinSeven) awarded a token.Oct 1 2020, 11:42 AM

Bohdan Lvov (ostapblender) awarded a token.Oct 1 2020, 4:02 PM

Pablo Dobarro (pablodp606) added a reviewer: Bastien Montagne (mont29).Oct 1 2020, 6:06 PM

Przemyslaw Golab (SirPigeonz) (n-pigeon) awarded a token.Oct 2 2020, 12:52 AM

It would be amazing to have the option to just add the new geometry as well and skip the boolean operation all together.

A lot of the time it is much easier to work with multiple intersecting geometry islands instead of one, big geometry island.

Add Join mode

Harbormaster completed remote builds in B10558: Diff 29568.Oct 4 2020, 8:39 PM

Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Enable Union mode for the trim tools to Sculpt: Union and Join mode for trim tools.Oct 4 2020, 8:40 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)

In D9066#224288, @Daniel Bystedt (dbystedt) wrote:

It would be amazing to have the option to just add the new geometry as well and skip the boolean operation all together.
A lot of the time it is much easier to work with multiple intersecting geometry islands instead of one, big geometry island.

I guess what you really want is an "insert mesh" brush. And yes, count me in, IT'S A MUST!

Yuichiro Fujita (chironamo) awarded a token.Oct 4 2020, 10:14 PM

Generally looks fine, besides points noted in comments below.

source/blender/editors/sculpt_paint/paint_mask.c
827	Why did you remove `INTERSECT` mode here?
835	`difference`
836	no need for a capital? Or else, please also add it to the `Difference` comment…
1103–1124	Better move the whole block inside the `if (trim_operation->mode != SCULPT_GESTURE_TRIM_JOIN)` condition, that way we have properly localized `boolean_mode` variable, which does not stay undefined in `SCULPT_GESTURE_TRIM_JOIN` case e.g.

This revision now requires changes to proceed.Oct 5 2020, 1:00 PM

Would it be possible to offer a mode for the generation of the new mesh where the thickness of the 3D mesh along the shape created is determined by how close to the edge each point on the surface is? Basically allowing for drawing sausages. Because that could be a really fast method for creating basic anatomical shapes for starting a sculpt of a character.

review update

Harbormaster completed remote builds in B10569: Diff 29600.Oct 5 2020, 6:25 PM

Pablo Dobarro (pablodp606) added inline comments.Oct 5 2020, 6:25 PM

source/blender/editors/sculpt_paint/paint_mask.c
827	Before this commits modes were not exposed in the UI, but I implemented them anyway to debug the boolean operation. The problem with exposing intersect is that it won't work with symmetry using the current implementation (if you intersect the trimming shape on one side of the object, it will remove the all the original mesh from the other side, so the result won't be symmetrical).