Page MenuHome
Differential D9068

Fix T81340: UBSan: member access within MemHead
AbandonedPublic
Actions

Authored by Ankit Meel (ankitm) on Oct 1 2020, 1:22 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T81340: UBSan: several runtime errors at launch.
Summary

Similar to rBc1cdde04e270: Fix T81100: ccl::Node: ASan SEGV due to bad pointer. Avoid creating invalid addresses for
accessing members' offsets (or size, type etc).

The warning:
mallocn_guarded_impl.c:1001:7: runtime error: member access within
null pointer of type 'MemHead (aka 'struct MemHead')

Fix T81340 (partially)

Diff Detail

Repository
rB Blender
Branch
ubmemhead (branched from master)
Build Status
Buildable 10502
Build 10502: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) created this revision.Oct 1 2020, 1:22 AM
Harbormaster completed remote builds in B10502: Diff 29442.Oct 1 2020, 1:22 AM
Ankit Meel (ankitm) requested review of this revision.Oct 1 2020, 1:22 AM
Ankit Meel (ankitm) mentioned this in T81340: UBSan: several runtime errors at launch. .Oct 1 2020, 1:24 AM
Campbell Barton (campbellbarton) accepted this revision.Oct 1 2020, 7:07 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Applied rB99fb853734cba8b778f9e60789ef51bd638d35da.

intern/guardedalloc/intern/mallocn_guarded_impl.c
157

Applied, kept ((char *)x) to avoid any ambiguity from order of operations.

This revision is now accepted and ready to land.Oct 1 2020, 7:07 AM
Campbell Barton (campbellbarton) abandoned this revision.Oct 1 2020, 7:08 AM
Campbell Barton (campbellbarton) mentioned this in rB99fb853734cb: Cleanup: avoid member access within null pointer.

Revision Contents
Changeset List

PathSize
intern/
guardedalloc/
intern/
3 lines

Diff 29442

View Options

intern/guardedalloc/intern/mallocn_guarded_impl.c

Loading...